From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH 11/13] kvm/powerpc: Handle some PAPR hcalls in the kernel Date: Tue, 17 May 2011 20:28:40 +1000 Message-ID: <20110517102840.GA7924@brick.ozlabs.ibm.com> References: <20110511103443.GA2837@brick.ozlabs.ibm.com> <20110511104530.GL2837@brick.ozlabs.ibm.com> <2C53DD5C-4F74-4FC4-9C65-4F401AE9AF78@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from ozlabs.org ([203.10.76.45]:54169 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753781Ab1EQLQA (ORCPT ); Tue, 17 May 2011 07:16:00 -0400 Content-Disposition: inline In-Reply-To: <2C53DD5C-4F74-4FC4-9C65-4F401AE9AF78@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 17, 2011 at 09:54:35AM +0200, Alexander Graf wrote: > Not sure I like the name - when is it used? :) When the real-mode hcall handler decides it can't handle the hcall and wants to pass it up. > Also, if it's not in the PAPR, the guest should never receive it, right? Right. It's purely an internal value. > > + /* See if this is something we can handle in real mode */ > > + cmpwi r12,0xc00 > > use the define please OK > > + beq hcall_real_mode > > This is simply a hcall helper, as the name suggests. So the comment > is slightly misleading - it should rather read like "Try to handle > hypercalls in real mode". Hmmm, OK, that's what it was trying to indicate. I could add "try" to the name if you like. > > + cmpdi r3,H_TOO_HARD > > + beq hcall_real_fallback > > Ah, very good. Please mark the constant as "for internal use only" > then, as that's certainly fine :). Cool, will do. > > + li r12,0xc00 > > use the define please :) OK. Thanks, Paul.