From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/2 V2] kvm tools: Add interval red-black tree helper Date: Tue, 17 May 2011 12:50:39 +0200 Message-ID: <20110517105039.GP22093@elte.hu> References: <1305628123-18440-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org, john@jfloren.net To: Sasha Levin Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:42021 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946Ab1EQKut (ORCPT ); Tue, 17 May 2011 06:50:49 -0400 Content-Disposition: inline In-Reply-To: <1305628123-18440-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > +#define max(x, y) ((x) > (y)) ? (x) : (y) Please have a look at tools/perf/util/include/linux/kernel.h where we have a type-safe version of the same - please put that into a header in tools/kvm/. ( There was some reason why perf could not use the kernel's min/max definitions, the details escape me. ) Looks nice otherwise! Acked-by: Ingo Molnar Ingo