From: Ingo Molnar <mingo@elte.hu>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, asias.hejun@gmail.com,
prasadjoshi124@gmail.com, gorcunov@gmail.com,
kvm@vger.kernel.org, john@jfloren.net
Subject: Re: [PATCH 1/2 V2] kvm tools: Add interval red-black tree helper
Date: Tue, 17 May 2011 13:57:40 +0200 [thread overview]
Message-ID: <20110517115740.GH13475@elte.hu> (raw)
In-Reply-To: <1305632336.12150.31.camel@sasha>
* Sasha Levin <levinsasha928@gmail.com> wrote:
> On Tue, 2011-05-17 at 12:50 +0200, Ingo Molnar wrote:
> > ( There was some reason why perf could not use the kernel's min/max
> > definitions, the details escape me. )
>
> perf's min/max are surrounded by #ifdef - unlike the ones in the
> kernel's <linux/kernel.h>.
> Commit messages didn't mention why, so I'll use the defs as they are in
> <linux/kernel.h>.
I think they were surrounded because in some contexts we could get them from
kernel headers.
If so then getting rid of the duplicate and sorting out the header dependency
is the right solution, so i think your approach is the right one :)
Thanks,
Ingo
prev parent reply other threads:[~2011-05-17 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 10:28 [PATCH 1/2 V2] kvm tools: Add interval red-black tree helper Sasha Levin
2011-05-17 10:28 ` [PATCH 2/2 V2] kvm tools: Add MMIO address mapper Sasha Levin
2011-05-17 10:51 ` Ingo Molnar
2011-05-17 10:50 ` [PATCH 1/2 V2] kvm tools: Add interval red-black tree helper Ingo Molnar
2011-05-17 11:38 ` Sasha Levin
2011-05-17 11:57 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517115740.GH13475@elte.hu \
--to=mingo@elte.hu \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox