From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2 V2] kvm tools: Add interval red-black tree helper
Date: Tue, 17 May 2011 13:57:40 +0200
Message-ID: <20110517115740.GH13475@elte.hu>
References: <1305628123-18440-1-git-send-email-levinsasha928@gmail.com>
 <20110517105039.GP22093@elte.hu>
 <1305632336.12150.31.camel@sasha>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: penberg@kernel.org, asias.hejun@gmail.com,
	prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org,
	john@jfloren.net
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:56815 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753987Ab1EQL5o (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 17 May 2011 07:57:44 -0400
Content-Disposition: inline
In-Reply-To: <1305632336.12150.31.camel@sasha>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> On Tue, 2011-05-17 at 12:50 +0200, Ingo Molnar wrote:
> > ( There was some reason why perf could not use the kernel's min/max
> >   definitions, the details escape me. ) 
> 
> perf's min/max are surrounded by #ifdef - unlike the ones in the
> kernel's <linux/kernel.h>.
> Commit messages didn't mention why, so I'll use the defs as they are in
> <linux/kernel.h>.

I think they were surrounded because in some contexts we could get them from 
kernel headers.

If so then getting rid of the duplicate and sorting out the header dependency 
is the right solution, so i think your approach is the right one :)

Thanks,

	Ingo