From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 01/14] kvm tools: Move disk image related code under disk directory Date: Wed, 18 May 2011 10:43:36 +0200 Message-ID: <20110518084336.GA6761@elte.hu> References: <1305706755-2816-1-git-send-email-asias.hejun@gmail.com> <20110518084231.GG14805@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , Cyrill Gorcunov , Sasha Levin , Prasad Joshi , kvm@vger.kernel.org To: Asias He Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:53606 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755174Ab1ERInm (ORCPT ); Wed, 18 May 2011 04:43:42 -0400 Content-Disposition: inline In-Reply-To: <20110518084231.GG14805@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: * Ingo Molnar wrote: > > * Asias He wrote: > > > This patch removes disk-image.c and qcow.c under disk directory. > > > > Signed-off-by: Asias He > > --- > > tools/kvm/Makefile | 4 ++-- > > tools/kvm/{ => disk}/disk-image.c | 0 > > btw., you may want to name it 'image.c' and thus have the intuitive: > > tools/kvm/disk-image.c => > tools/kvm/disk/image.c > > replacement instead of tools/kvm/disk/disk-image.c which repeats 'disk' twice. oh, stupid me: you rename it to core.c in patch #2! I should really do what i do normally, read patch series from the end backwards ;-) Thanks, Ingo