From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 14/14] kvm tools: Print debug info for
 qcow1_nowrite_sector
Date: Wed, 18 May 2011 10:45:03 +0200
Message-ID: <20110518084503.GH14805@elte.hu>
References: <1305706755-2816-1-git-send-email-asias.hejun@gmail.com>
 <1305706755-2816-14-git-send-email-asias.hejun@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org
To: Asias He <asias.hejun@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:53941 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755317Ab1ERIpK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 May 2011 04:45:10 -0400
Content-Disposition: inline
In-Reply-To: <1305706755-2816-14-git-send-email-asias.hejun@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Asias He <asias.hejun@gmail.com> wrote:

> Print debug info when we are in qcow1_nowrite_sector
> 
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
>  tools/kvm/disk/qcow.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/kvm/disk/qcow.c b/tools/kvm/disk/qcow.c
> index dd11ed97..29964b9 100644
> --- a/tools/kvm/disk/qcow.c
> +++ b/tools/kvm/disk/qcow.c
> @@ -323,6 +323,7 @@ static ssize_t qcow1_write_sector(struct disk_image *disk, u64 sector, void *src
>  static ssize_t qcow1_nowrite_sector(struct disk_image *disk, u64 sector, void *src, u32 src_len)
>  {
>  	/* I/O error */
> +	info("qcow1_nowrite_sector: no write support\n");

Could we make this pr_info(), to roughly match the in-kernel equivalent?

There's also pr_warn(), pr_err(), etc.

For us poor kernel namespace infested folks :)

Thanks,

	Ingo