public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com,
	gorcunov@gmail.com, levinsasha928@gmail.com,
	chaitanyakulkarni15@gmail.com, ashwini.kulkarni@gmail.com
Subject: Re: [PATCH v1 1/3] kvm tools: Close the disk images after the guest shuts down
Date: Wed, 18 May 2011 13:15:31 +0200	[thread overview]
Message-ID: <20110518111531.GF16556@elte.hu> (raw)
In-Reply-To: <1305713837-18889-1-git-send-email-prasadjoshi124@gmail.com>


* Prasad Joshi <prasadjoshi124@gmail.com> wrote:

> @@ -583,6 +585,11 @@ int kvm_cmd_run(int argc, const char **argv, const char *prefix)
>  			exit_code	= 1;
>  	}
>  
> +	for (i = 0; i < MAX_DISK_IMAGES; i++) {
> +		if (image_disks[i])
> +			disk_image__close(image_disks[i]);
> +	}

Isnt this a method that the disk/image subsystem wants to provide? Or at least 
it should move into an inline - kvm_cmd_run() is *way* too big already at 200 
lines and these patches are how it grows!

it should split into several helpers, setting up various aspects of the 
context, then one separate helper doing the vcpu startup and waiting.

Thanks,

	Ingo

      parent reply	other threads:[~2011-05-18 11:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 10:17 [PATCH v1 1/3] kvm tools: Close the disk images after the guest shuts down Prasad Joshi
2011-05-18 10:17 ` [PATCH v1 2/3] kvm tools: Release memoty allocated during virtio block initialization Prasad Joshi
2011-05-18 10:25   ` Pekka Enberg
2011-05-18 11:11   ` Ingo Molnar
2011-05-18 10:17 ` [PATCH v1 3/3] kvm tools: Add QCOW level2 caching support Prasad Joshi
2011-05-18 10:27   ` Pekka Enberg
2011-05-18 10:41     ` Prasad Joshi
2011-05-18 11:18       ` Pekka Enberg
2011-05-18 11:10     ` Ingo Molnar
2011-05-18 11:27   ` Sasha Levin
2011-05-18 10:31 ` [PATCH v1 1/3] kvm tools: Close the disk images after the guest shuts down Sasha Levin
2011-05-18 10:36   ` Prasad Joshi
2011-05-18 11:15 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518111531.GF16556@elte.hu \
    --to=mingo@elte.hu \
    --cc=ashwini.kulkarni@gmail.com \
    --cc=asias.hejun@gmail.com \
    --cc=chaitanyakulkarni15@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox