From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/3] KVM: x86 emulator: Place insn_fetch helpers together
Date: Wed, 18 May 2011 09:51:12 -0300
Message-ID: <20110518125112.GA9894@amt.cnet>
References: <20110515005458.9964c7b8.takuya.yoshikawa@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: avi@redhat.com, kvm@vger.kernel.org,
	yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:18982 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757090Ab1ERNSZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 May 2011 09:18:25 -0400
Content-Disposition: inline
In-Reply-To: <20110515005458.9964c7b8.takuya.yoshikawa@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, May 15, 2011 at 12:54:58AM +0900, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
> 
> The two macros need special care to use:
>   Assume rc, ctxt, ops and done exist outside of them.
>   Can goto outside.
> 
> Considering the fact that these are used only in decode functions,
> moving these right after do_insn_fetch() seems to be a right thing
> to improve the readability.
> 
> We also rename do_fetch_insn_byte() to do_insn_fetch_byte() to be
> consistent.
> 
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>

Applied all, thanks.