Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC

Pekka Enberg
2011-05-24T11:27:00Z

Hi Avi,

On Tue, May 24, 2011 at 2:22 PM, Avi Kivity <avi@redhat.com> wrote:
>> The point is to follow Linux kernel conventions and idioms (and share
>> code) as much as possible so it's familiar to devs who are already
>> working on the kernel. That's why section tricks seem more appropriate
>> than using constructor to me. Or is there some technical advantage to
>> using constructors?
>
> You get to reuse infrastructure that's already there.
>
> Things like using sections and s/uint64_t/u64/ look anti-reuse to me.
>  Userspace isn't the kernel, for better or for worse.

Not really. The type thing is pretty much required once you start
using kernel code (as we learned the hard way).

Btw, constructor attribute doesn't really seem like a good fit for
"late_initcall" type of thing:

The constructor attribute causes the function to be called
automatically before execution enters main ()

What am I missing here?

Pekka