Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC

Avi Kivity
2011-05-24T11:23:15Z

On 05/24/2011 12:55 PM, Pekka Enberg wrote:
> On Tue, May 24, 2011 at 12:10 PM, Paolo Bonzini<pbonzini@redhat.com> wrote:
> > I know portability is not relevant to tools/kvm/, but using unportable
> > tricks for the sake of using them is a direct way to NIH. But oh well all
> > of tools/kvm/ is NIH after all. :)
>
> Hmm?
>
> The point is to follow Linux kernel conventions and idioms (and share
> code) as much as possible so it's familiar to devs who are already
> working on the kernel. That's why section tricks seem more appropriate
> than using constructor to me. Or is there some technical advantage to
> using constructors?

You get to reuse infrastructure that's already there.

Things like using sections and s/uint64_t/u64/ look anti-reuse to me.
Userspace isn't the kernel, for better or for worse.

--
error compiling committee.c: too many arguments to function