Re: [PATCH 2/5 V2] kvm tools: Add video mode to kernel initialization

Ingo Molnar
2011-05-23T11:30:59Z

* Sasha Levin <levinsasha928@gmail.com> wrote:

> bool kvm__load_kernel(struct kvm *kvm, const char *kernel_filename,
> - const char *initrd_filename, const char *kernel_cmdline);
> + const char *initrd_filename, const char *kernel_cmdline, u16 vidmode);

Suggestion for future cleanup: we really want to gros a 'struct kernel_params'
kind of thing which could be passed along here by address.

That would make it easier to extent it with whatever may come along in the
future, and would make the code look cleaner as well.

Thanks,

Ingo