Re: [PATCH 5/5 V2] kvm tools: Initialize and use VESA and VNC

Avi Kivity
2011-05-24T14:37:23Z

On 05/24/2011 02:41 PM, Avi Kivity wrote:
>
>> We switched to u64 and friends for two reasons: (1) using uint*_t
>> turned out to be painful when using kernel headers (e.g., mptables,
>> e820, etc.) and (2) we want to be as close as possible to the coding
>> style of tools/perf to be able to reuse their code in the future.
>>
>
> Regarding this reuse, I see it's done by copy/paste. Won't it be
> better to have tools/lib and have tools/perf and tools/kvm use that?
>

Another thing, I believe reuse of actual kernel code has limited
utility. The kernel has vast infrastructure and porting all of it to
userspace would be a huge undertaking. It's pretty common for code to
use printk(), kmalloc(), slab caches, rcu, various locks, per-cpu
variables. Are you going to port all of it? and maintain it when it
changes?

It's a lot easier to use the native userspace stacks.

--
error compiling committee.c: too many arguments to function