[PATCH 1/2] KVM-test: control: Fix of spliting augments

[PATCH 1/2] KVM-test: control: Fix of spliting augments

[Amos Kong]

../../bin/autotest control --args='only=boot kernel_cmdline="root=/dev/vda ro quite" only=qcow2'

original result:
only boot
kernel_cmdline="root = /dev/vda ro quite"
only qcow2'

new result:
only boot
kernel_cmdline="root=/dev/vda ro quite"
only qcow2'

Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
 client/tests/kvm/control |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/tests/kvm/control b/client/tests/kvm/control
index c887a3e..959d2bc 100644
--- a/client/tests/kvm/control
+++ b/client/tests/kvm/control
@@ -55,7 +55,7 @@ if args:
     # We get test parameters from command line
     for arg in args:
         try:
-            (key, value) = re.findall("(.*)=(.*)", arg)[0]
+            (key, value) = re.findall("^(\w+)=(.*)", arg)[0]
             if key == "only":
                 str += "only %s\n" % value
             elif key == "no":

[PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments

[Amos Kong]

Appended kernel cmdline should be involved by quotation marks.
-append 'root=/dev/vda ro ..'

Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
 client/virt/kvm_vm.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index c9bb273..343488f 100644
--- a/client/virt/kvm_vm.py
+++ b/client/virt/kvm_vm.py
@@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
             return " -initrd '%s'" % filename
 
         def add_kernel_cmdline(help, cmdline):
-            return " -append %s" % cmdline
+            return " -append '%s'" % cmdline
 
         def add_testdev(help, filename):
             return (" -chardev file,id=testlog,path=%s"

Re: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments

[Cong Wang]

Amos, thanks for fixing it!

Re: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments

[Lucas Meneghel Rodrigues]

On Tue, May 24, 2011 at 11:24 PM, Amos Kong <akong@redhat.com> wrote:
> Appended kernel cmdline should be involved by quotation marks.
> -append 'root=/dev/vda ro ..'

Applied, thanks!

> Reported-by: Cong Wang <amwang@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  client/virt/kvm_vm.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
> index c9bb273..343488f 100644
> --- a/client/virt/kvm_vm.py
> +++ b/client/virt/kvm_vm.py
> @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
>             return " -initrd '%s'" % filename
>
>         def add_kernel_cmdline(help, cmdline):
> -            return " -append %s" % cmdline
> +            return " -append '%s'" % cmdline
>
>         def add_testdev(help, filename):
>             return (" -chardev file,id=testlog,path=%s"
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>



-- 
Lucas