Re: [PATCHv2 10/14] virtio_net: limit xmit polling

Rusty Russell
2011-05-26T03:28:23Z

On Wed, 25 May 2011 09:07:59 +0300, "Michael S. Tsirkin" <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On Wed, May 25, 2011 at 11:05:04AM +0930, Rusty Russell wrote:
> Hmm I'm not sure I got it, need to think about this.
> I'd like to go back and document how my design was supposed to work.
> This really should have been in commit log or even a comment.
> I thought we need a min, not a max.
> We start with this:
>
> while ((c = (virtqueue_get_capacity(vq) < 2 + MAX_SKB_FRAGS) &&
> (skb = get_buf)))
> kfree_skb(skb);
> return !c;
>
> This is clean and simple, right? And it's exactly asking for what we need.

No, I started from the other direction:

for (i = 0; i < 2; i++) {
skb = get_buf();
if (!skb)
break;
kfree_skb(skb);
}

ie. free two packets for every one we're about to add. For steady state
that would work really well. Then we hit the case where the ring seems
full after we do the add: at that point, screw latency, and just try to
free all the buffers we can.

> on the normal path min == 2 so we're low latency but we keep ahead on
> average. min == 0 for the "we're out of capacity, we may have to stop
> the queue".
>
> Does the above make sense at all?

It makes sense, but I think it's a classic case where incremental
improvements aren't as good as starting from scratch.

Cheers,
Rusty.