From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: KVM: x86: use proper port value when checking io instruction
 permission (v2)
Date: Thu, 26 May 2011 10:07:37 +0300
Message-ID: <20110526070737.GB29458@redhat.com>
References: <20110524171120.GA19906@amt.cnet>
 <20110524172706.GC22042@redhat.com>
 <20110525181820.GA14921@amt.cnet>
 <4DDDF3D6.3000505@redhat.com>
 <20110526065511.GA29458@redhat.com>
 <4DDDFB07.2050909@redhat.com>
 <4DDDFB78.9070307@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
	Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37214 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750932Ab1EZHHl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 26 May 2011 03:07:41 -0400
Content-Disposition: inline
In-Reply-To: <4DDDFB78.9070307@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, May 26, 2011 at 10:04:24AM +0300, Avi Kivity wrote:
> On 05/26/2011 10:02 AM, Avi Kivity wrote:
> >
> >>Can
> >>c->op_bytes ever be 1?
> >
> >in %dx, %al
> >
> 
> er, that doesn't change op_bytes.
Yep.

>                                    Still, op_bytes is irrelevant for
> SrcDX, the 16-bit version is always used.
> 
If SrcDX/DstDX will be used only for decoding in/out instruction
then yes. Otherwise it is nice to have more general decoder.

--
			Gleb.