public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, john@jfloren.net, kvm@vger.kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com,
	prasadjoshi124@gmail.com
Subject: Re: [PATCH 1/4] kvm tools: Add ioeventfd support
Date: Fri, 27 May 2011 13:29:55 +0200	[thread overview]
Message-ID: <20110527112955.GC25909@elte.hu> (raw)
In-Reply-To: <1306494176.3217.16.camel@lappy>


* Sasha Levin <levinsasha928@gmail.com> wrote:

> > > +	pthread_create(&thread, NULL, ioeventfd__thread, NULL);
> > > +}
> > 
> > Shouldnt this use the thread pool, so that we know about each and 
> > every worker thread we have started, in one central place?
> 
> Our thread pool currently responds to events - it runs a callback 
> if it has received a notification to do so. It doesn't manage 
> threads which have to run all the time like in this case.

then it should perhaps be extended to handle that, because it's 
always good to have explicit enumeration of all worker threads, and 
because:

> > (This might have relevance, see the big-reader-lock mail i sent 
> > earlier today.)

Thanks,

	Ingo

  reply	other threads:[~2011-05-27 11:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 10:36 [PATCH 1/4] kvm tools: Add ioeventfd support Sasha Levin
2011-05-27 10:36 ` [PATCH 2/4] kvm tools: Use ioeventfd in virtio-blk Sasha Levin
2011-05-27 10:37 ` [PATCH 3/4] kvm tools: Use ioeventfd in virtio-net Sasha Levin
2011-05-27 10:37 ` [PATCH 4/4] kvm tools: Use ioeventfd in virtio-rng Sasha Levin
2011-05-27 10:47 ` [PATCH 1/4] kvm tools: Add ioeventfd support Stefan Hajnoczi
2011-05-27 10:57   ` Sasha Levin
2011-05-27 10:52 ` Pekka Enberg
2011-05-27 10:54 ` Ingo Molnar
2011-05-27 11:02   ` Sasha Levin
2011-05-27 11:29     ` Ingo Molnar [this message]
2011-05-27 11:30   ` Pekka Enberg
2011-05-27 11:38     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110527112955.GC25909@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=john@jfloren.net \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox