From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/4] kvm tools: Add ioeventfd support Date: Fri, 27 May 2011 13:29:55 +0200 Message-ID: <20110527112955.GC25909@elte.hu> References: <1306492621-10208-1-git-send-email-levinsasha928@gmail.com> <20110527105450.GA25909@elte.hu> <1306494176.3217.16.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Sasha Levin Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:54254 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589Ab1E0L36 (ORCPT ); Fri, 27 May 2011 07:29:58 -0400 Content-Disposition: inline In-Reply-To: <1306494176.3217.16.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > > > + pthread_create(&thread, NULL, ioeventfd__thread, NULL); > > > +} > > > > Shouldnt this use the thread pool, so that we know about each and > > every worker thread we have started, in one central place? > > Our thread pool currently responds to events - it runs a callback > if it has received a notification to do so. It doesn't manage > threads which have to run all the time like in this case. then it should perhaps be extended to handle that, because it's always good to have explicit enumeration of all worker threads, and because: > > (This might have relevance, see the big-reader-lock mail i sent > > earlier today.) Thanks, Ingo