From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 1/4] kvm tools: Add ioeventfd support Date: Fri, 27 May 2011 13:38:55 +0200 Message-ID: <20110527113855.GE25909@elte.hu> References: <1306492621-10208-1-git-send-email-levinsasha928@gmail.com> <20110527105450.GA25909@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sasha Levin , john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Pekka Enberg Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:42651 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752990Ab1E0LjJ (ORCPT ); Fri, 27 May 2011 07:39:09 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: * Pekka Enberg wrote: > Hi Ingo, > > On Fri, May 27, 2011 at 1:54 PM, Ingo Molnar wrote: > > A sidenote: i think 'struct kvm *kvm' was a naming mistake - it's way > > too aspecific, it tells us nothing. What is a 'kvm'? > > Why, an instance of a kernel virtual machine, of course! It was the > very first thing I wrote for this project! Oh, that is way too funny: i never thought of 'KVM' as a 'kernel virtual machine' :-/ It's the name of a cool kernel subsystem - not the name of one instance of a virtual machine. > On Fri, May 27, 2011 at 1:54 PM, Ingo Molnar wrote: > > A much better name would be 'struct machine *machine', hm? Even if > > everyone agrees this would be a separate patch, obviously. > > Well, I don't really think 'struct machine' is that much better. The > obvious benefits of 'struct kvm' is that it's the same name that's > used by Qemu and libkvm and maps nicely to '/dev/kvm'. To me /dev/kvm is what interfaces to 'KVM' - where 'KVM' is the magic, axiomatic name for the aforementioned cool kernel subsystem! :-) > If you really, really wanna change it, I could use some more > convincing or bribes of some sort. No, i guess the naming is just fine, i just need to rewire 5 years worth of neural pathways ;-) I'll save the bribes for a worthier goal! :-) Thanks, Ingo