From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2 3/4] kvm tools: Use ioeventfd in virtio-net Date: Sun, 29 May 2011 14:51:48 +0200 Message-ID: <20110529125148.GA28836@elte.hu> References: <1306513120-28794-1-git-send-email-levinsasha928@gmail.com> <1306513120-28794-3-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Sasha Levin Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:33368 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992Ab1E2Mv6 (ORCPT ); Sun, 29 May 2011 08:51:58 -0400 Content-Disposition: inline In-Reply-To: <1306513120-28794-3-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > Use ioeventfds to receive notifications of IO events in virtio-net. > Doing so prevents an exit every time we receive/send a packet. > > Signed-off-by: Sasha Levin > --- > tools/kvm/virtio/net.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) This needs the fix below to build on 32-bit. Thanks, Ingo Signed-off-by: Ingo Molnar diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c index 5c39c43..6916af6 100644 --- a/tools/kvm/virtio/net.c +++ b/tools/kvm/virtio/net.c @@ -283,7 +283,7 @@ static bool virtio_net_pci_io_out(struct ioport *ioport, struct kvm *kvm, u16 po static void ioevent_callback(struct kvm *kvm, void *param) { - virtio_net_handle_callback(kvm, (u64)param); + virtio_net_handle_callback(kvm, (u64)(long)param); } static struct ioport_operations virtio_net_io_ops = { @@ -416,7 +416,7 @@ void virtio_net__init(const struct virtio_net_parameters *params) .io_len = sizeof(u16), .fn = ioevent_callback, .datamatch = i, - .fn_ptr = (void *)i, + .fn_ptr = (void *)(long)i, .fn_kvm = params->kvm, .fd = eventfd(0, 0), };