From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2 2/8] kvm tools: Remove wrong global definition of kvm Date: Mon, 30 May 2011 10:38:21 +0200 Message-ID: <20110530083821.GE30513@elte.hu> References: <1306744247-26051-1-git-send-email-levinsasha928@gmail.com> <1306744247-26051-2-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Sasha Levin Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:51330 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752085Ab1E3Iia (ORCPT ); Mon, 30 May 2011 04:38:30 -0400 Content-Disposition: inline In-Reply-To: <1306744247-26051-2-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > Signed-off-by: Sasha Levin > --- > tools/kvm/include/kvm/mptable.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/kvm/include/kvm/mptable.h b/tools/kvm/include/kvm/mptable.h > index 3c8362d..8557ae8 100644 > --- a/tools/kvm/include/kvm/mptable.h > +++ b/tools/kvm/include/kvm/mptable.h > @@ -1,7 +1,7 @@ > #ifndef KVM_MPTABLE_H_ > #define KVM_MPTABLE_H_ > > -struct kvm kvm; > +struct kvm; heh, that was a funny typo. Btw., could we do a 'make test' run that includes every header file in a standalone .c file and checks whether that builds without warnings/errors? They are enumerated in the Makefile already. That would check tools/kvm/ headers for sanity, type encapsulaion and self-sufficiently and would prevent the kind of header-dependencies spaghetti mess the kernel got into after ~20 years of randomly added kernel dependencies. Thanks, Ingo