Re: [PATCH v2 1/8] kvm tools: Use correct value for user signal base

Sasha Levin
2011-05-30T08:41:08Z

On Mon, 2011-05-30 at 10:35 +0200, Ingo Molnar wrote:
> * Sasha Levin <levinsasha928@gmail.com> wrote:
>
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> > ---
> > tools/kvm/include/kvm/kvm.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/tools/kvm/include/kvm/kvm.h b/tools/kvm/include/kvm/kvm.h
> > index f951f2d..6a17362 100644
> > --- a/tools/kvm/include/kvm/kvm.h
> > +++ b/tools/kvm/include/kvm/kvm.h
> > @@ -11,7 +11,7 @@
> > #define KVM_32BIT_GAP_SIZE (512 << 20)
> > #define KVM_32BIT_GAP_START ((1ULL << 32) - KVM_32BIT_GAP_SIZE)
> >
> > -#define SIGKVMEXIT (SIGUSR1 + 2)
> > +#define SIGKVMEXIT (SIGRTMIN + 0)
>
> I think the changelog is missing essential information like what the
> effects of this bug were in practice. ('none' is a good answer as
> well.)

None - It made us exit when receiving SIGUSR2, which wasn't in use at
that time (Now it's used to pause the guest - thats how I found it).

--

Sasha.