Re: [PATCH v2 6/8] kvm tools: Add rwlock wrapper

Ingo Molnar
2011-05-30T09:56:56Z

* Sasha Levin <levinsasha928@gmail.com> wrote:

> I'm just saying that we're limited to as many VCPU threads as we
> can create. br_read_lock() won't do anything on a non-VCPU thread,
> which makes it impossible to test it on non-VCPUs.

btw., i wondered about that limit - don't we want to fix it?

I mean, there's no fundamental reason why brlocks should do 'nothing'
in worker threads. In fact it's a subtle breakage waiting AFAICS.

We should have enumeration for all threads that kvm starts, and that
we can use for a generic pause/resume facility. Can you see anything
that prevents that model?

Thanks,

Ingo