Re: [PATCH v2 2/8] kvm tools: Remove wrong global definition of kvm

Ingo Molnar
2011-05-30T08:38:30Z

* Sasha Levin <levinsasha928@gmail.com> wrote:

> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> tools/kvm/include/kvm/mptable.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/kvm/include/kvm/mptable.h b/tools/kvm/include/kvm/mptable.h
> index 3c8362d..8557ae8 100644
> --- a/tools/kvm/include/kvm/mptable.h
> +++ b/tools/kvm/include/kvm/mptable.h
> @@ -1,7 +1,7 @@
> #ifndef KVM_MPTABLE_H_
> #define KVM_MPTABLE_H_
>
> -struct kvm kvm;
> +struct kvm;

heh, that was a funny typo.

Btw., could we do a 'make test' run that includes every header file
in a standalone .c file and checks whether that builds without
warnings/errors? They are enumerated in the Makefile already.

That would check tools/kvm/ headers for sanity, type encapsulaion and
self-sufficiently and would prevent the kind of header-dependencies
spaghetti mess the kernel got into after ~20 years of randomly added
kernel dependencies.

Thanks,

Ingo