Re: [PATCH] kvm: Fix build warnings

Ingo Molnar
2011-05-31T10:27:11Z

* Avi Kivity <avi@redhat.com> wrote:

> On 05/31/2011 10:38 AM, Ingo Molnar wrote:
> >* Borislav Petkov<bp@alien8.de> wrote:
> >
> >> +++ b/arch/x86/kvm/paging_tmpl.h
> >> @@ -121,7 +121,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
> >> gva_t addr, u32 access)
> >> {
> >> pt_element_t pte;
> >> - pt_element_t __user *ptep_user;
> >> + pt_element_t __user *uninitialized_var(ptep_user);
> >
> >Note that doing this is actually actively dangerous for two reasons.
> >
> >
>
> <snip lots of good advice>
>
> > Please fix it instead.
>
> s/instead/in addition/; while all those changes are good, they are
> much too large for 3.0. Let's push the simple fix for 3.0 and
> queue the bigger refactoring to 3.1.

Yeah, that's probably wise, this is a tricky function.

Thanks,

Ingo