From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kvm tools, i8042: Fix device init failure
Date: Thu, 2 Jun 2011 15:40:37 +0200
Message-ID: <20110602134037.GA26199@elte.hu>
References: <1307021895-20434-1-git-send-email-penberg@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:52664 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932083Ab1FBNkk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 2 Jun 2011 09:40:40 -0400
Content-Disposition: inline
In-Reply-To: <1307021895-20434-1-git-send-email-penberg@kernel.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

>  static bool kbd_in(struct ioport *ioport, struct kvm *kvm, u16 port, void *data, int size, u32 count)
>  {
> -	u32 result;
> -
> -	if (port == I8042_COMMAND_REG) {
> -		result = kbd_read_status();
> -		ioport__write8(data, (char)result);
> -	} else {
> -		result = kbd_read_data();
> -		ioport__write32(data, result);
> +	switch (port) {
> +	case I8042_COMMAND_REG: {
> +		u8 value = kbd_read_status();
> +		ioport__write8(data, value);
> +		break;
> +	}
> +	case I8042_DATA_REG: {
> +		u32 value = kbd_read_data();
> +		ioport__write32(data, value);
> +		break;
>  	}
> +	default:
> +		break;

should we BUG_ON() [or WARN_ON()] in that 'default' case?

> +	default:
> +		break;

ditto. This could have caught the bug straight away, right?

Thanks,

	Ingo