From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v7 3/4] Mask function7 ebx against host capability word9
Date: Thu, 2 Jun 2011 22:27:05 -0300
Message-ID: <20110603012705.GE5226@amt.cnet>
References: <5D8008F58939784290FAB48F5497519844E9278EFF@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Yang, Wei Y" <wei.y.yang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49012 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752094Ab1FCBm7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 2 Jun 2011 21:42:59 -0400
Content-Disposition: inline
In-Reply-To: <5D8008F58939784290FAB48F5497519844E9278EFF@shsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jun 01, 2011 at 09:07:51PM +0800, Yang, Wei Y wrote:
> 
> This patch masks CPUID leaf 7 ebx against host capability word9.
> 
>  Signed-off-by: Yang, Wei <wei.y.yang@intel.com>
>  Signed-off-by: Shan, Haitao <haitao.shan@intel.com>
>  Signed-off-by: Li, Xin <xin.li@intel.com>
> 
> ---
>  arch/x86/kvm/x86.c |   21 ++++++++++++++++++++-
>  1 files changed, 20 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 91bfc40..d27202d 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2353,6 +2353,10 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
>  		F(ACE2) | F(ACE2_EN) | F(PHE) | F(PHE_EN) |
>  		F(PMM) | F(PMM_EN);
>  
> +	/* cpuid 7.0.ebx */
> +	const u32 kvm_supported_word9_x86_features =
> +		F(SMEP);
> +
>  	/* all calls to cpuid_count() should be made on the same cpu */
>  	get_cpu();
>  	do_cpuid_1_ent(entry, function, index);
> @@ -2387,7 +2391,7 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
>  		}
>  		break;
>  	}
> -	/* function 4 and 0xb have additional index. */
> +	/* function 4 has additional index. */
>  	case 4: {
>  		int i, cache_type;
>  
> @@ -2404,6 +2408,21 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
>  		}
>  		break;
>  	}
> +	case 7: {
> +		entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> +		/* Mask ebx against host capbability word 9 */
> +		if (index == 0) {
> +			entry->ebx &= kvm_supported_word9_x86_features;
> +			cpuid_mask(&entry->edx, 9);

ebx?

> +		}
> +		else
> +			entry->ebx = 0;

indentation is wrong.


> +		entry->eax = 0;
> +		entry->ecx = 0;
> +		entry->edx = 0;
> +		break;
> +	}
> +	/* function 0xb has additional index. */
>  	case 0xb: {
>  		int i, level_type;