public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	penberg@kernel.org, kvm@vger.kernel.org, asias.hejun@gmail.com,
	gorcunov@gmail.com
Subject: Re: [PATCH] kvm tools: Add 'kvm pause' command
Date: Fri, 3 Jun 2011 09:02:07 +0200	[thread overview]
Message-ID: <20110603070207.GB15375@elte.hu> (raw)
In-Reply-To: <BANLkTi=xF5HPXajQp1_MX86mvhgyo4VBow@mail.gmail.com>


* Prasad Joshi <prasadjoshi124@gmail.com> wrote:

> >  struct cmd_struct kvm_commands[] = {
> > +       { "pause", kvm_cmd_pause, NULL,         0 },
> 
> We automatically generate <include/common-cmds.h> header file that 
> lists the command options with kvm. Should we ensure 'pause' is 
> added to the file? I think then './kvm help' will display 'pause' 
> as one of the possible command.

That is done by adding the new command to command-list.txt - then the 
Makefile will generate everything correctly.

Thanks,

	Ingo

  reply	other threads:[~2011-06-03  7:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 20:22 [PATCH] kvm tools: Add 'kvm pause' command Sasha Levin
2011-06-02 22:59 ` Prasad Joshi
2011-06-03  7:02   ` Ingo Molnar [this message]
2011-06-03  6:29 ` Pekka Enberg
2011-06-03  6:34   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603070207.GB15375@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox