From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer
 output target
Date: Fri, 3 Jun 2011 18:52:25 +0200
Message-ID: <20110603165225.GA18795@elte.hu>
References: <1307116779-572-1-git-send-email-penberg@kernel.org>
 <1307116779-572-3-git-send-email-penberg@kernel.org>
 <20110603162631.GA17203@elte.hu>
 <20110603162856.GA17415@elte.hu>
 <20110603163346.GB17415@elte.hu>
 <alpine.DEB.2.00.1106031936380.2203@tiger>
 <20110603164500.GB17964@elte.hu>
 <alpine.DEB.2.00.1106031946000.807@tiger>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>,
	John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:55493 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752311Ab1FCQwg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 3 Jun 2011 12:52:36 -0400
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1106031946000.807@tiger>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Fri, 3 Jun 2011, Ingo Molnar wrote:
> >Oh ... because the SDL library is not present on that box and it
> >silently did not get built.
> >
> >Now *that* is not an obvious failure pattern ;-)
> 
> Oh, sorry about that. I'll just drop the '--sdl' command line option
> if the library is not present. Does that sound OK to you?

it would be better to display a meaningful error message in that case 
and not run, the user very likely has added --sdl expecting a 
framebuffer to pop up!

Thanks,

	Ingo