From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 3/3] kvm tools, ui: Add support for SDL framebuffer
 output target
Date: Fri, 3 Jun 2011 18:58:05 +0200
Message-ID: <20110603165805.GA19247@elte.hu>
References: <1307116779-572-1-git-send-email-penberg@kernel.org>
 <1307116779-572-3-git-send-email-penberg@kernel.org>
 <20110603162631.GA17203@elte.hu>
 <20110603162856.GA17415@elte.hu>
 <20110603163346.GB17415@elte.hu>
 <alpine.DEB.2.00.1106031936380.2203@tiger>
 <20110603164500.GB17964@elte.hu>
 <alpine.DEB.2.00.1106031946000.807@tiger>
 <20110603165225.GA18795@elte.hu>
 <alpine.DEB.2.00.1106031954300.807@tiger>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>,
	John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:57325 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754137Ab1FCQ6T (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 3 Jun 2011 12:58:19 -0400
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1106031954300.807@tiger>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Fri, 3 Jun 2011, Ingo Molnar wrote:
> >it would be better to display a meaningful error message in that case
> >and not run, the user very likely has added --sdl expecting a
> >framebuffer to pop up!
> 
> Is this better?
> 
> penberg@tiger:~/linux/tools/kvm$ ./kvm run --sdl -p "root=/dev/vda1"
> -d ~/images/debian_squeeze_amd64_standard.img
>   # kvm run -k ../../arch/x86/boot/bzImage -m 320 -c 2
>   Warning: Config tap device error. Are you root?
>   Fatal: SDL support not compiled in.

Yeah! I'd suggest such a wording:

    Fatal: SDL support not compiled in. (install the SDL-dev[el] package)

Thanks,

	Ingo