From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
John Floren <john@jfloren.net>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa()
Date: Mon, 6 Jun 2011 13:11:26 +0400 [thread overview]
Message-ID: <20110606091126.GA23248@sun> (raw)
In-Reply-To: <BANLkTikWPM6RA9xf+r+A9_jenA+iCb3dyg@mail.gmail.com>
On Mon, Jun 06, 2011 at 12:09:25PM +0300, Pekka Enberg wrote:
...
> > Type conversion will do the work but having explicit masking is
> > a way better I believe, at least it makes this code snippet notable.
>
> True but the patch description is bogus as it really doesn't _fix_ anything.
>
> Pekka
Yup, I somehow missed 'fix' word in log, looked only in patch body, sorry.
Cyrill
next prev parent reply other threads:[~2011-06-06 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 19:37 [PATCH 1/2] kvm tools, vesa: Cleanup code in bios/int10.c Pekka Enberg
2011-06-03 19:37 ` [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa() Pekka Enberg
2011-06-03 19:43 ` Cyrill Gorcunov
2011-06-06 8:28 ` Avi Kivity
2011-06-06 8:37 ` Cyrill Gorcunov
2011-06-06 9:09 ` Pekka Enberg
2011-06-06 9:11 ` Cyrill Gorcunov [this message]
2011-06-03 19:45 ` [PATCH 1/2] kvm tools, vesa: Cleanup code in bios/int10.c Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606091126.GA23248@sun \
--to=gorcunov@gmail.com \
--cc=avi@redhat.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox