From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 2/2] kvm tools, vesa: Fix 'ah' access in int10_vesa()
Date: Mon, 6 Jun 2011 13:11:26 +0400
Message-ID: <20110606091126.GA23248@sun>
References: <1307129824-8396-1-git-send-email-penberg@kernel.org>
 <1307129824-8396-2-git-send-email-penberg@kernel.org>
 <4DEC8FC8.8090601@redhat.com>
 <20110606083707.GA21290@sun>
 <BANLkTikWPM6RA9xf+r+A9_jenA+iCb3dyg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>, John Floren <john@jfloren.net>,
	Sasha Levin <levinsasha928@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:46963 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753948Ab1FFJLc (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 Jun 2011 05:11:32 -0400
Received: by fxm17 with SMTP id 17so2269449fxm.19
        for <kvm@vger.kernel.org>; Mon, 06 Jun 2011 02:11:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <BANLkTikWPM6RA9xf+r+A9_jenA+iCb3dyg@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jun 06, 2011 at 12:09:25PM +0300, Pekka Enberg wrote:
...
> > Type conversion will do the work but having explicit masking is
> > a way better I believe, at least it makes this code snippet notable.
> 
> True but the patch description is bogus as it really doesn't _fix_ anything.
> 
>                         Pekka

Yup, I somehow missed 'fix' word in log, looked only in patch body, sorry.

	Cyrill