public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: rusty@rustcorp.com.au
Cc: kvm@vger.kernel.org
Subject: [PATCH v2] virtio-spec: Fix wrong bit number of device status
Date: Tue, 7 Jun 2011 21:09:42 +0800	[thread overview]
Message-ID: <20110607130942.GA16234@t400> (raw)
In-Reply-To: <1307451139-20613-1-git-send-email-akong@redhat.com>


qemu-kvm/hw/virtio_config.h:
 #define VIRTIO_CONFIG_S_ACKNOWLEDGE     1
 #define VIRTIO_CONFIG_S_DRIVER          2
 #define VIRTIO_CONFIG_S_DRIVER_OK       4
 #define VIRTIO_CONFIG_S_FAILED          0x80

virtio-spec:
ACKNOWLEDGE(1) :
DRIVER(2)      :
DRIVER_OK(3)   :
FAILED(128)    :

The spec refers to bit numbers and the headers use absolute numbers,
they are not consistent.

it shoule be 'FAILED(8)'.
2^(8-1) = 128

Changes from V1:
- Fix wrong patch body

Signed-off-by: Amos Kong <akong@redhat.com>
---
 virtio-spec.lyx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 448af76..1fc3e59 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -1552,7 +1552,7 @@ FAILED
 \begin_inset space ~
 \end_inset
 
-(128) Indicates that something went wrong in the guest, and it has given
+(8) Indicates that something went wrong in the guest, and it has given
  up on the device.
  This could be an internal error, or the driver didn't like the device for
  some reason, or even a fatal error during device operation.
-- 
1.7.1


  reply	other threads:[~2011-06-07 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 12:52 [PATCH] virtio-spec: Fix wrong bit number of device status akong
2011-06-07 13:09 ` Amos Kong [this message]
2011-06-07 23:35   ` [PATCH v2] " Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607130942.GA16234@t400 \
    --to=akong@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox