From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amos Kong Subject: [PATCH v2] virtio-spec: Fix wrong bit number of device status Date: Tue, 7 Jun 2011 21:09:42 +0800 Message-ID: <20110607130942.GA16234@t400> References: <1307451139-20613-1-git-send-email-akong@redhat.com> Reply-To: Amos Kong Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org To: rusty@rustcorp.com.au Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39711 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754631Ab1FGNJv (ORCPT ); Tue, 7 Jun 2011 09:09:51 -0400 Content-Disposition: inline In-Reply-To: <1307451139-20613-1-git-send-email-akong@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: qemu-kvm/hw/virtio_config.h: #define VIRTIO_CONFIG_S_ACKNOWLEDGE 1 #define VIRTIO_CONFIG_S_DRIVER 2 #define VIRTIO_CONFIG_S_DRIVER_OK 4 #define VIRTIO_CONFIG_S_FAILED 0x80 virtio-spec: ACKNOWLEDGE(1) : DRIVER(2) : DRIVER_OK(3) : FAILED(128) : The spec refers to bit numbers and the headers use absolute numbers, they are not consistent. it shoule be 'FAILED(8)'. 2^(8-1) = 128 Changes from V1: - Fix wrong patch body Signed-off-by: Amos Kong --- virtio-spec.lyx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 448af76..1fc3e59 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -1552,7 +1552,7 @@ FAILED \begin_inset space ~ \end_inset -(128) Indicates that something went wrong in the guest, and it has given +(8) Indicates that something went wrong in the guest, and it has given up on the device. This could be an internal error, or the driver didn't like the device for some reason, or even a fatal error during device operation. -- 1.7.1