From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK Date: Tue, 7 Jun 2011 22:52:36 +0200 Message-ID: <201106072252.36636.arnd@arndb.de> References: <1307478315-15564-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: KVM list , kvm-ppc@vger.kernel.org To: Alexander Graf Return-path: In-Reply-To: <1307478315-15564-1-git-send-email-agraf@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tuesday 07 June 2011 22:25:15 Alexander Graf wrote: > +static long kvm_vcpu_compat_ioctl(struct file *filp, > + unsigned int ioctl, unsigned long arg) > +{ > + struct kvm_vcpu *vcpu = filp->private_data; > + void __user *argp = (void __user *)arg; Converting a compat user argument into a pointer should use the compat_ptr() function to do the right thing on s390. Otherwise your patch looks good. Arnd