[Bug 37262] New: VNC access to KVM VM is unusable

[Bug 37262] New: VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262

           Summary: VNC access to KVM VM is unusable
           Product: Virtualization
           Version: unspecified
    Kernel Version: 3.0.0-rc1
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: kvm
        AssignedTo: virtualization_kvm@kernel-bugs.osdl.org
        ReportedBy: stefan.bosak@gmail.com
        Regression: No


Kernels: 2.6.39-git8 - 3.0.0-rc1
QemuKVM: latest from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git

After try access to VNC console of KVM VM
keyboard and video interactions is not proceed
by VM. Newly created VM without OS which started
for installation process of any OS dropped
interactions after few inputs from user, host
and hosted machine running without problems.
I have tested this on 3 independent servers,
3 independent workstations.

Used VNC clients:
- from Linux: TightVNC Viewer version 1.3.10
- from Windows: RealVNC Viewer 4.1.3

Other activities except VNC access are OK.


Kernel: 2.6.39-rc1-git2
QemuKVM: latest from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git

On this server VNC access to all KVM VM works well.

Please try to test VNC access to KVM VM
and fix issue when problem occurs. As
I can see some fixes for input and tty
are in kernel 3.0.0-rc2.

Thank you for your time.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262


Avi Kivity <avi@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |avi@redhat.com




--- Comment #1 from Avi Kivity <avi@redhat.com>  2011-06-12 11:50:14 ---
Does SDL work correctly?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #2 from Steve <stefan.bosak@gmail.com>  2011-06-12 13:24:24 ---
I also test qemu-kvm compiled with SDL, VM work
correctly, but VNC access occur the same result.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #3 from Avi Kivity <avi@redhat.com>  2011-06-12 13:42:48 ---
On 06/12/2011 04:24 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
>

Please post a tcpdump of the vnc session.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #4 from Steve <stefan.bosak@gmail.com>  2011-06-12 13:54:51 ---
I checked tcpdump output, it seems that
communication is not quite correct.
Should I need use some options for
tcpdump output for you (like -vvv) ?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #5 from Avi Kivity <avi@redhat.com>  2011-06-12 13:57:45 ---
On 06/12/2011 04:54 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
>
>
>
>
>
> --- Comment #4 from Steve<stefan.bosak@gmail.com>   2011-06-12 13:54:51 ---
> I checked tcpdump output, it seems that
> communication is not quite correct.
> Should I need use some options for
> tcpdump output for you (like -vvv) ?
>

What do you mean by "not quite correct"?

Please post the entire binary dump (with -s 2000 -w /tmp/dump port 
5901).  Just don't type any passwords.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #6 from Steve <stefan.bosak@gmail.com>  2011-06-12 14:41:56 ---
Created an attachment (id=61662)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=61662)
tcpdump output

tcpdump outputs from client & server

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #7 from Steve <stefan.bosak@gmail.com>  2011-06-12 14:43:06 ---
I don't use authentication for VNC.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #8 from Avi Kivity <avi@redhat.com>  2011-06-12 14:58:02 ---
Everything seems normal.  The client sends an update request, gets an update
30ms later.

What is slow? interactivity or just display?  Try watching a movie in a small
window (so no keyboard/mouse is involved).

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #9 from Avi Kivity <avi@redhat.com>  2011-06-12 15:00:21 ---
Oh, the connection just drops without a user request? and qemu stays up?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #10 from Steve <stefan.bosak@gmail.com>  2011-06-12 15:39:05 ---
VM stay up without any problem, only VNC access "freeze".
User need to close VNC client create new VNC connection
from client and see video output but keyoard & video
interaction simultaneously.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #11 from Steve <stefan.bosak@gmail.com>  2011-06-12 15:39:59 ---
No keyboard & video interaction simultaneously.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #12 from Steve <stefan.bosak@gmail.com>  2011-06-12 15:53:59 ---
I try to watch movie, video output of VNC
also freeze, but VM is not affected by this.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #13 from Avi Kivity <avi@redhat.com>  2011-06-12 15:55:30 ---
Right.  There's a client update request at frame 188 which has no 
responses except TCP ACKs.

Is it possible for you to do a bisect?  It looks like a very basic bug here.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #14 from Steve <stefan.bosak@gmail.com>  2011-06-12 16:00:27 ---
I could give you full access to one machine.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #15 from Steve <stefan.bosak@gmail.com>  2011-06-12 16:11:01 ---
When it's ok I can send authentication directly to your email.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #16 from Avi Kivity <avi@redhat.com>  2011-06-12 16:18:10 ---
I prefer that you do the bisect yourself.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #17 from Steve <stefan.bosak@gmail.com>  2011-06-12 16:23:03 ---
Could you write me what & how to do please, thanks.
Currently I have to go away, then I will be continue
with some information from you.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #18 from Avi Kivity <avi@redhat.com>  2011-06-12 17:01:51 ---
Bisect instructions:

install git

$ git clone 
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
$ cd linux-2.6
$ cp /path/to/.config .config

# if you don't have a specialized .config already:
$ make localmodconfig

$ git bisect start v2.6.39 v2.3.39-rc1

$ make -j20 && sudo make modules_install install

[reboot to new kernel]
[test]

If it works okay:

   $ git bisect good

otherwise:

   $ git bisect bad

if git says there is work to do:

    [goto 'make' step]

otherwise:

    post the message that says: xxxxxxxxxxxx is first bad commit

Note: please test v2.6.39 and v2.6.39-rc1 first, to be sure they're bad 
and good, respectively.  You can do that using

   $ git checkout v2.6.39
   $ make -j20 && sudo make modules_install install
   [reboot and test]
   $ git checkout v2.6.39-rc1
   $ make -j20 && sudo make modules_install install
   [reboot and test]

Note2: if the problem also occurs when qemu-kvm is running in a guest, 
you can run all of the tests in a  guest, which should be a more 
pleasant experience.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #19 from Steve <stefan.bosak@gmail.com>  2011-06-12 19:30:11 ---
Ok. Thanks for instructions.
I will make some tests and then I will inform you about the results.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #20 from Steve <stefan.bosak@gmail.com>  2011-06-12 22:19:51 ---
I tested this kernel tags from branch
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git:
v3.0-rc2: same problem
v2.6.39-rc1: same problem
v2.6.39: same problem
v2.6.38: no problem; works as expected

Now i will try to test tags between v2.6.38 =< . < v2.6.39
and found lastest kernel version which works fine.

In every test i proceed:
1) before compilation for tested kernel
   make mrproper
   cp path/.config kernel_path/
   make menuconfig
   make -j34 && make modules_install install
2) recompile udev from master branch
   git://git.kernel.org/pub/scm/linux/hotplug/udev.git
3) recompile qemu-kvm from master branch
   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git
4) reboot machine to prepared kernel
5) run KVM VM & test VNC access from more locations & VNC clients

I will inform you about my tests.

Thanks for your help.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #21 from Steve <stefan.bosak@gmail.com>  2011-06-12 22:46:08 ---
Latest tested kernel tag worked without VNC problem: 2.6.38-rc8.

Please fix reported VNC bug.

Thank you for your time.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #22 from Steve <stefan.bosak@gmail.com>  2011-06-12 22:49:19 ---
Git positions:

Previous HEAD position was 61c4f2c... Linux 2.6.39
HEAD is now at 0ce790e... Linux 2.6.39-rc1

Previous HEAD position was 0ce790e... Linux 2.6.39-rc1
HEAD is now at 521cb40... Linux 2.6.38

Previous HEAD position was 521cb40... Linux 2.6.38
HEAD is now at a5abba9... Linux 2.6.38-rc8

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #23 from Steve <stefan.bosak@gmail.com>  2011-06-12 22:58:37 ---
Latest final tag of 2.6.38:

author    Linus Torvalds <torvalds@linux-foundation.org>    
    Tue, 15 Mar 2011 01:20:32 +0000 (18:20 -0700)
committer    Linus Torvalds <torvalds@linux-foundation.org>    
    Tue, 15 Mar 2011 01:20:32 +0000 (18:20 -0700)
commit    521cb40b0c44418a4fd36dc633f575813d59a43d
tree    fec2224bffa4c1ffa38c3d60af17fd6d9be3fb0c    tree | snapshot
parent    59766edc79da0583eff7d0a9e1049b0d3c5676b0    commit | diff

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #24 from Steve <stefan.bosak@gmail.com>  2011-06-12 23:22:58 ---
I found this commits:

author    Jeff Brown <jeffbrown@google.com>    
    Mon, 18 Apr 2011 17:08:02 +0000 (10:08 -0700)
committer    Dmitry Torokhov <dmitry.torokhov@gmail.com>    
    Mon, 18 Apr 2011 17:15:43 +0000 (10:15 -0700)
commit    80b4895aa4578e9372d76cd4063f82d0c3994d77
tree    0ac167a8b17e2550ff2d996d153ecbb59e05e643    tree | snapshot
parent    9fb0f14e31b6101a0cc69a333b43541044f9b0a6    commit | diff

author    Olaf Hering <olaf@aepfle.de>    
    Thu, 17 Mar 2011 05:11:46 +0000 (22:11 -0700)
committer    Dmitry Torokhov <dmitry.torokhov@gmail.com>    
    Thu, 17 Mar 2011 06:24:02 +0000 (23:24 -0700)
commit    8c3c283e6bf463ab498d6e7823aff6c4762314b6
tree    32a5aaf486e95afc321f4c7514129b7e48b883b6    tree | snapshot
parent    53a2b81c4e659d894aadc56715c8d8a9afa60d67    commit | diff

author    Jeff Brown <jeffbrown@google.com>    
    Wed, 13 Apr 2011 06:29:38 +0000 (23:29 -0700)
committer    Dmitry Torokhov <dmitry.torokhov@gmail.com>    
    Wed, 13 Apr 2011 06:35:24 +0000 (23:35 -0700)
commit    9fb0f14e31b6101a0cc69a333b43541044f9b0a6
tree    a384acf387f5dff50e0c3a56fa54336dedd286c5    tree | snapshot
parent    b1e064b81e238d47cb56544b34c9baf473e09837    commit | diff

author    GuanXuetao <gxt@mprc.pku.edu.cn>    
    Sat, 26 Feb 2011 13:39:10 +0000 (21:39 +0800)
committer    GuanXuetao <gxt@mprc.pku.edu.cn>    
    Thu, 17 Mar 2011 01:19:20 +0000 (09:19 +0800)
commit    ce443ab5fd536941da1d529ba3963324f941fc29
tree    5551778e3ae1d623410ad98cbeefe941fc29dd28    tree | snapshot
parent    d10e4a660d11212a41ac5d2c116a655e25e2d38a    commit | diff

author    Linus Torvalds <torvalds@linux-foundation.org>    
    Thu, 7 Apr 2011 18:33:04 +0000 (11:33 -0700)
committer    Linus Torvalds <torvalds@linux-foundation.org>    
    Thu, 7 Apr 2011 18:33:04 +0000 (11:33 -0700)
commit    7bc30c23c8ace3821a6732bfbe7e8f1b0995a63e
tree    3440c323f331fb2c0b5e84c206b3c73d70826ee6    tree | snapshot
parent    ccfeef0ff76ebd632ae51bc56700f0072c4f1864    commit | diff
parent    bd22f5cfcfe8f68bf43b72daf4530cd7eedc9b7a    commit | diff

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #25 from Avi Kivity <avi@redhat.com>  2011-06-13 08:11:52 ---
What do these commits mean?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #26 from Steve <stefan.bosak@gmail.com>  2011-06-13 08:59:11 ---
I found some commit that could affect this but it's only my assumption.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #27 from Avi Kivity <avi@redhat.com>  2011-06-13 08:59:59 ---
Please run the bisect and we'll know for sure.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #28 from Steve <stefan.bosak@gmail.com>  2011-06-13 09:15:33 ---
I used git bitsect as you described above but
i didn't see any output, probably i did something wrong.

git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
make_kernel
reboot_to_new_kernel
git bisect start v2.6.39 v2.3.39-rc1

when booted kernel, tested VNC & problem occurs:
git bisect bad

I didn't see any output.

Should you write me where could i do mistake ?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #29 from Avi Kivity <avi@redhat.com>  2011-06-13 09:22:55 ---
You should run 'git bisect bad' in the directory where you have the 
linux-2.6 clone.  git will then check out a new commit for you to test 
(and tell you about it).

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #30 from Avi Kivity <avi@redhat.com>  2011-06-13 09:35:05 ---
On 06/13/2011 01:19 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> --- Comment #20 from Steve<stefan.bosak@gmail.com>   2011-06-12 22:19:51 ---
> I tested this kernel tags from branch
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git:
> v3.0-rc2: same problem
> v2.6.39-rc1: same problem
> v2.6.39: same problem
> v2.6.38: no problem; works as expected

In light of this, the bisect start command should be:

$ git bisect start v2.6.39-rc1 v2.6.38

(since the problem was introduced between 2.6.48 and 2.6.39-rc1).

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #31 from Steve <stefan.bosak@gmail.com>  2011-06-13 09:55:41 ---
Of course I did bitsect in cloned git directory but i didn't see any output.

I need to try this:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
git bisect start v2.6.39-rc1 v2.6.38
perform_make&test
git bisect bad # i could see info
git checkout v2.6.39-rc1
perform_make&test
git bisect bad # i could see info
git checkout v2.6.38
perform_make&test
git bisect good # i could see info

Am I correct ?

Thanks for your info.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #32 from Avi Kivity <avi@redhat.com>  2011-06-13 12:18:56 ---
On 06/13/2011 12:55 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> Of course I did bitsect in cloned git directory but i didn't see any output.

Strange, did you follow the procedure exactly?  What's the output after 
'git bisect start'?

> I need to try this:
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> git bisect start v2.6.39-rc1 v2.6.38
> perform_make&test
> git bisect bad # i could see info
> git checkout v2.6.39-rc1
> perform_make&test
> git bisect bad # i could see info
> git checkout v2.6.38
> perform_make&test
> git bisect good # i could see info

No need to test v2.6.38 and v2.6.39-rc1 separately, you're already sure 
they're good and bad respectively, yes?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #33 from Steve <stefan.bosak@gmail.com>  2011-06-13 14:05:34 ---
(In reply to comment #32)
> On 06/13/2011 12:55 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> > Of course I did bitsect in cloned git directory but i didn't see any output.
> 
> Strange, did you follow the procedure exactly?  What's the output after 
> 'git bisect start'?

1) initial git clone
2) first run git bisect start:
   no output
3) after second run (git bisect start):
   Already on 'master'
4) git bisect log:
   git bisect start
5) git bisect replay:
   No logfile given
6) git --version:
   git version 1.7.5.2.317.g391b14.dirty
7) git bisect start v2.6.39-rc1 v2.6.38:
   Already on 'master'
   Bisecting: 4616 revisions left to test after this (roughly 12 steps)
   [179198373cf374f0ef793f1023c1cdd83b53674d] Merge branch 'nfs-for-2.6.39'
   of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
8) git bisect log:
   # bad: [0ce790e7d736cedc563e1fb4e998babf5a4dbc3d] Linux 2.6.39-rc1
   # good: [521cb40b0c44418a4fd36dc633f575813d59a43d] Linux 2.6.38
   git bisect start 'v2.6.39-rc1' 'v2.6.38'
9) git bisect replay:
   No logfile given

It seems initial git bisect start should be run first.

> 
> > I need to try this:
> > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> > git bisect start v2.6.39-rc1 v2.6.38
> > perform_make&test
> > git bisect bad # i could see info
> > git checkout v2.6.39-rc1
> > perform_make&test
> > git bisect bad # i could see info
> > git checkout v2.6.38
> > perform_make&test
> > git bisect good # i could see info
> 
> No need to test v2.6.38 and v2.6.39-rc1 separately, you're already sure 
> they're good and bad respectively, yes?

I need to know exactly what i do to understand it correctly,
thank you for your assistance & time investments to help me.
I will test it again and give you requested data.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #34 from Avi Kivity <avi@redhat.com>  2011-06-13 14:12:50 ---
On 06/13/2011 05:05 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> 7) git bisect start v2.6.39-rc1 v2.6.38:
>     Already on 'master'
>     Bisecting: 4616 revisions left to test after this (roughly 12 steps)
>     [179198373cf374f0ef793f1023c1cdd83b53674d] Merge branch 'nfs-for-2.6.39'
>     of git://git.linux-nfs.org/projects/trondmy/nfs-2.6

When you get this, build, reboot, and test.  Then do 'git bisect good' 
or 'git bisect bad' as appropriate.

After 'git bisect good' or 'git bisect bad' you will need to build and 
test again, until git tells you to stop ('xxxxx is first bad commit').

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #35 from Steve <stefan.bosak@gmail.com>  2011-06-13 14:27:31 ---
(In reply to comment #34)
> On 06/13/2011 05:05 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> > 7) git bisect start v2.6.39-rc1 v2.6.38:
> >     Already on 'master'
> >     Bisecting: 4616 revisions left to test after this (roughly 12 steps)
> >     [179198373cf374f0ef793f1023c1cdd83b53674d] Merge branch 'nfs-for-2.6.39'
> >     of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
> 
> When you get this, build, reboot, and test.  Then do 'git bisect good' 
> or 'git bisect bad' as appropriate.
> 
> After 'git bisect good' or 'git bisect bad' you 
> will need to build and test again,

this was very important information for me:
rebuild it again and test without any change
after run git bisect good or bad marking

> until git tells you to stop ('xxxxx is first bad commit').

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #36 from Steve <stefan.bosak@gmail.com>  2011-06-15 17:10:04 ---
git bisect log:
# bad: [0ce790e7d736cedc563e1fb4e998babf5a4dbc3d] Linux 2.6.39-rc1
# good: [521cb40b0c44418a4fd36dc633f575813d59a43d] Linux 2.6.38
git bisect start 'v2.6.39-rc1' 'v2.6.38'
# good: [179198373cf374f0ef793f1023c1cdd83b53674d] Merge branch
'nfs-for-2.6.39' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
git bisect good 179198373cf374f0ef793f1023c1cdd83b53674d
# bad: [da23ef0549d4205ca9b576cf6cce9a80d0c3e43a] adfs: add hexadecimal
filetype suffix option
git bisect bad da23ef0549d4205ca9b576cf6cce9a80d0c3e43a
# bad: [e16b396ce314b2bcdfe6c173fe075bf8e3432368] Merge branch 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
git bisect bad e16b396ce314b2bcdfe6c173fe075bf8e3432368
# bad: [411f5c7a502769ccc0377c5ba36cb0b283847ba8] Merge branch 'devel-stable'
of master.kernel.org:/home/rmk/linux-2.6-arm
git bisect bad 411f5c7a502769ccc0377c5ba36cb0b283847ba8
# bad: [6d7ed21d17e640b120b902a314143e5ef4917a70] Merge branches 'defcfg',
'drivers' and 'cyberpro-next' of master.kernel.org:/home/rmk/linux-2.6-arm
git bisect bad 6d7ed21d17e640b120b902a314143e5ef4917a70

After this VNC access is OK.
Now it's time to mark as git bisect good
and then git tells some information.
Am I right ?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #37 from Steve <stefan.bosak@gmail.com>  2011-06-15 17:19:44 ---
I will continue with git bisect good/bad
and try to find bad commmit.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #38 from Steve <stefan.bosak@gmail.com>  2011-06-15 21:44:37 ---
I found it:

5d163b1c9d6e5562dcdfd6cd471f237f1502bb35 is the first bad commit
commit 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
Author: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Date:   Wed Mar 9 15:43:00 2011 +0800

    KVM: MMU: introduce a common function to get no-dirty-logged slot

    Cleanup the code of pte_prefetch_gfn_to_memslot and
mapping_level_dirty_bitmap

    Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    Signed-off-by: Avi Kivity <avi@redhat.com>

:040000 040000 23f9e0cbbeba9b82067fc50ffc3fdd0c2982a206
28607b5635b3cb78048f9e270ddefde39f1ed25f M      arch

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #39 from Steve <stefan.bosak@gmail.com>  2011-06-15 21:46:15 ---
Here is complete git bisect log:

# bad: [0ce790e7d736cedc563e1fb4e998babf5a4dbc3d] Linux 2.6.39-rc1
# good: [521cb40b0c44418a4fd36dc633f575813d59a43d] Linux 2.6.38
git bisect start 'v2.6.39-rc1' 'v2.6.38'
# good: [179198373cf374f0ef793f1023c1cdd83b53674d] Merge branch
'nfs-for-2.6.39' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
git bisect good 179198373cf374f0ef793f1023c1cdd83b53674d
# bad: [da23ef0549d4205ca9b576cf6cce9a80d0c3e43a] adfs: add hexadecimal
filetype suffix option
git bisect bad da23ef0549d4205ca9b576cf6cce9a80d0c3e43a
# bad: [e16b396ce314b2bcdfe6c173fe075bf8e3432368] Merge branch 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
git bisect bad e16b396ce314b2bcdfe6c173fe075bf8e3432368
# bad: [411f5c7a502769ccc0377c5ba36cb0b283847ba8] Merge branch 'devel-stable'
of master.kernel.org:/home/rmk/linux-2.6-arm
git bisect bad 411f5c7a502769ccc0377c5ba36cb0b283847ba8
# bad: [6d7ed21d17e640b120b902a314143e5ef4917a70] Merge branches 'defcfg',
'drivers' and 'cyberpro-next' of master.kernel.org:/home/rmk/linux-2.6-arm
git bisect bad 6d7ed21d17e640b120b902a314143e5ef4917a70
# good: [c98a0eb0e90d1caa8a92913cd45462102cbd5eaf] [SCSI] sd: Logical Block
Provisioning update
git bisect good c98a0eb0e90d1caa8a92913cd45462102cbd5eaf
# good: [804f18536984939622ddca60ab6b25743e0ec68d] Merge branch
'stable/xen.pm.bug-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen
git bisect good 804f18536984939622ddca60ab6b25743e0ec68d
# good: [49b26e26e4b7b94753b39f7edb0c34f3d1c4c167] KVM: MMU: do not record gfn
in kvm_mmu_pte_write
git bisect good 49b26e26e4b7b94753b39f7edb0c34f3d1c4c167
# good: [9c9585e0e96f8340d704256db00b2ec28240c36e] Merge branches 'aaci',
'mmci-dma', 'pl' and 'pl011' into drivers
git bisect good 9c9585e0e96f8340d704256db00b2ec28240c36e
# bad: [0f53b5b1c0baae4f949ac0721a55b7a2158dda01] KVM: MMU: cleanup pte write
path
git bisect bad 0f53b5b1c0baae4f949ac0721a55b7a2158dda01
# good: [831ca6093ca486060721f5c3c74f97b10f3172b9] KVM: SVM: Load %gs earlier
if CONFIG_X86_32_LAZY_GS=n
git bisect good 831ca6093ca486060721f5c3c74f97b10f3172b9
# good: [1aa8ceef0312a6aae7dd863a120a55f1637b361d] KVM: fix kvmclock regression
due to missing clock update
git bisect good 1aa8ceef0312a6aae7dd863a120a55f1637b361d
# bad: [5d163b1c9d6e5562dcdfd6cd471f237f1502bb35] KVM: MMU: introduce a common
function to get no-dirty-logged slot
git bisect bad 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
# good: [40dcaa9f69fa303ddcb5ea65baf4efefed3aec4b] KVM: fix rcu usage in
init_rmode_* functions
git bisect good 40dcaa9f69fa303ddcb5ea65baf4efefed3aec4b

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

Re: [Bug 37262] VNC access to KVM VM is unusable

[Avi Kivity]

On 06/16/2011 12:44 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
>
>
>
>
>
> --- Comment #38 from Steve<stefan.bosak@gmail.com>   2011-06-15 21:44:37 ---
> I found it:
>
> 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35 is the first bad commit
> commit 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
> Author: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> Date:   Wed Mar 9 15:43:00 2011 +0800
>
>      KVM: MMU: introduce a common function to get no-dirty-logged slot
>
>      Cleanup the code of pte_prefetch_gfn_to_memslot and
> mapping_level_dirty_bitmap
>
>      Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
>      Signed-off-by: Avi Kivity<avi@redhat.com>
>
> :040000 040000 23f9e0cbbeba9b82067fc50ffc3fdd0c2982a206
> 28607b5635b3cb78048f9e270ddefde39f1ed25f M      arch
>

Xiao?  Can you take a look?

Steve, can you confirm by:

$ git bisect reset
$ git checkout 5d163b1c9d6e5562dc
[build and test, verify failure]
$ git checkout 5d163b1c9d6e5562dc^
[build and test, verify success]

-- 
error compiling committee.c: too many arguments to function

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #40 from Avi Kivity <avi@redhat.com>  2011-06-16 14:00:24 ---
On 06/16/2011 12:44 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
>
>
>
>
>
> --- Comment #38 from Steve<stefan.bosak@gmail.com>   2011-06-15 21:44:37 ---
> I found it:
>
> 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35 is the first bad commit
> commit 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
> Author: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> Date:   Wed Mar 9 15:43:00 2011 +0800
>
>      KVM: MMU: introduce a common function to get no-dirty-logged slot
>
>      Cleanup the code of pte_prefetch_gfn_to_memslot and
> mapping_level_dirty_bitmap
>
>      Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
>      Signed-off-by: Avi Kivity<avi@redhat.com>
>
> :040000 040000 23f9e0cbbeba9b82067fc50ffc3fdd0c2982a206
> 28607b5635b3cb78048f9e270ddefde39f1ed25f M      arch
>

Xiao?  Can you take a look?

Steve, can you confirm by:

$ git bisect reset
$ git checkout 5d163b1c9d6e5562dc
[build and test, verify failure]
$ git checkout 5d163b1c9d6e5562dc^
[build and test, verify success]

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #41 from Steve <stefan.bosak@gmail.com>  2011-06-16 14:15:09 ---
(In reply to comment #40)
> On 06/16/2011 12:44 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> > https://bugzilla.kernel.org/show_bug.cgi?id=37262
> >
> >
> >
> >
> >
> > --- Comment #38 from Steve<stefan.bosak@gmail.com>   2011-06-15 21:44:37 ---
> > I found it:
> >
> > 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35 is the first bad commit
> > commit 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
> > Author: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> > Date:   Wed Mar 9 15:43:00 2011 +0800
> >
> >      KVM: MMU: introduce a common function to get no-dirty-logged slot
> >
> >      Cleanup the code of pte_prefetch_gfn_to_memslot and
> > mapping_level_dirty_bitmap
> >
> >      Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> >      Signed-off-by: Avi Kivity<avi@redhat.com>
> >
> > :040000 040000 23f9e0cbbeba9b82067fc50ffc3fdd0c2982a206
> > 28607b5635b3cb78048f9e270ddefde39f1ed25f M      arch
> >
> 
> Xiao?  Can you take a look?
> 
> Steve, can you confirm by:
> 
> $ git bisect reset
> $ git checkout 5d163b1c9d6e5562dc
> [build and test, verify failure]
> $ git checkout 5d163b1c9d6e5562dc^
> [build and test, verify success]

Ok, I will try it tonight and then give you report.

Thank you for your time.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #42 from Steve <stefan.bosak@gmail.com>  2011-06-16 16:45:46 ---
(In reply to comment #41)
> (In reply to comment #40)
> > On 06/16/2011 12:44 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=37262
> > >
> > >
> > >
> > >
> > >
> > > --- Comment #38 from Steve<stefan.bosak@gmail.com>   2011-06-15 21:44:37 ---
> > > I found it:
> > >
> > > 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35 is the first bad commit
> > > commit 5d163b1c9d6e5562dcdfd6cd471f237f1502bb35
> > > Author: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> > > Date:   Wed Mar 9 15:43:00 2011 +0800
> > >
> > >      KVM: MMU: introduce a common function to get no-dirty-logged slot
> > >
> > >      Cleanup the code of pte_prefetch_gfn_to_memslot and
> > > mapping_level_dirty_bitmap
> > >
> > >      Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
> > >      Signed-off-by: Avi Kivity<avi@redhat.com>
> > >
> > > :040000 040000 23f9e0cbbeba9b82067fc50ffc3fdd0c2982a206
> > > 28607b5635b3cb78048f9e270ddefde39f1ed25f M      arch
> > >
> > 
> > Xiao?  Can you take a look?
> > 
> > Steve, can you confirm by:
> > 
> > $ git bisect reset
> > $ git checkout 5d163b1c9d6e5562dc
> > [build and test, verify failure]
i can confirm: test failed
> > $ git checkout 5d163b1c9d6e5562dc^
> > [build and test, verify success]
i can confirm: test was successful
> 
> Ok, I will try it tonight and then give you report.
> 
> Thank you for your time.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #43 from Steve <stefan.bosak@gmail.com>  2011-06-16 20:39:32 ---
Solution of this bug is very simple:

arch/x86/kvm/mmu.c:

static bool mapping_level_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t large_gfn)
{
return (gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true) == NULL)
? true : false;
}

Only opposite condition.
Please commit when it's possible.

Thank you for your time

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

Re: [Bug 37262] VNC access to KVM VM is unusable

[Xiao Guangrong]

On 06/17/2011 04:39 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
> 
> 
> 
> 
> 
> --- Comment #43 from Steve <stefan.bosak@gmail.com>  2011-06-16 20:39:32 ---
> Solution of this bug is very simple:
> 
> arch/x86/kvm/mmu.c:
> 
> static bool mapping_level_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t large_gfn)
> {
> return (gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true) == NULL)
> ? true : false;
> }
> 
> Only opposite condition.
> Please commit when it's possible.
> 

Yes, it is the reason, thanks for your time and great job, i am so
sorry, this is caused by my mistake :-(

And this is the fix patch from you and i did little cleanup

From: Steve <stefan.bosak@gmail.com>
Subject: [PATCH] KVM: MMU: fix opposite condition in mapping_level_dirty_bitmap

The condition is opposite, it always maps huge page for the dirty tracked page

Reported-by: Steve <stefan.bosak@gmail.com>
Signed-off-by: Steve <stefan.bosak@gmail.com>
---
 arch/x86/kvm/mmu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 19ebb76..15afa1e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -549,7 +549,7 @@ gfn_to_memslot_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t gfn,
 
 static bool mapping_level_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t large_gfn)
 {
-	return gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true);
+	return !gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true);
 }
 
 static int mapping_level(struct kvm_vcpu *vcpu, gfn_t large_gfn)
-- 
1.7.5.4

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #44 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org>  2011-06-17 03:49:38 ---
Reply-To: xiaoguangrong@cn.fujitsu.com

On 06/17/2011 04:39 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=37262
> 
> 
> 
> 
> 
> --- Comment #43 from Steve <stefan.bosak@gmail.com>  2011-06-16 20:39:32 ---
> Solution of this bug is very simple:
> 
> arch/x86/kvm/mmu.c:
> 
> static bool mapping_level_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t large_gfn)
> {
> return (gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true) == NULL)
> ? true : false;
> }
> 
> Only opposite condition.
> Please commit when it's possible.
> 

Yes, it is the reason, thanks for your time and great job, i am so
sorry, this is caused by my mistake :-(

And this is the fix patch from you and i did little cleanup

From: Steve <stefan.bosak@gmail.com>
Subject: [PATCH] KVM: MMU: fix opposite condition in mapping_level_dirty_bitmap

The condition is opposite, it always maps huge page for the dirty tracked page

Reported-by: Steve <stefan.bosak@gmail.com>
Signed-off-by: Steve <stefan.bosak@gmail.com>
---
 arch/x86/kvm/mmu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 19ebb76..15afa1e 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -549,7 +549,7 @@ gfn_to_memslot_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t
gfn,

 static bool mapping_level_dirty_bitmap(struct kvm_vcpu *vcpu, gfn_t large_gfn)
 {
-    return gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true);
+    return !gfn_to_memslot_dirty_bitmap(vcpu, large_gfn, true);
 }

 static int mapping_level(struct kvm_vcpu *vcpu, gfn_t large_gfn)

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262


Steve <stefan.bosak@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CODE_FIX




--- Comment #45 from Steve <stefan.bosak@gmail.com>  2011-06-17 07:00:16 ---
I prefer unabridged syntax in specific
situation, reduction has the same result.
Now VNC access works as expected.

Thank you for your time.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

Re: [Bug 37262] VNC access to KVM VM is unusable

[Avi Kivity]

On 06/17/2011 05:25 AM, Xiao Guangrong wrote:
> From: Steve<stefan.bosak@gmail.com>
> Subject: [PATCH] KVM: MMU: fix opposite condition in mapping_level_dirty_bitmap
>
> The condition is opposite, it always maps huge page for the dirty tracked page
>

Thanks, applied and queued.

-- 
error compiling committee.c: too many arguments to function

[Bug 37262] VNC access to KVM VM is unusable

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=37262





--- Comment #46 from Avi Kivity <avi@redhat.com>  2011-06-19 08:50:13 ---
On 06/17/2011 05:25 AM, Xiao Guangrong wrote:
> From: Steve<stefan.bosak@gmail.com>
> Subject: [PATCH] KVM: MMU: fix opposite condition in mapping_level_dirty_bitmap
>
> The condition is opposite, it always maps huge page for the dirty tracked page
>

Thanks, applied and queued.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.