From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S\. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>,
Kevin Wolf <kwolf@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Riku Voipio <riku.voipio@iki.fi>,
Richard Henderson <rth@twiddle.net>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Stefan Weil <weil@mail.berlios.de>,
Jan Kiszka <jan.kiszka@siemens.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Aurelien Jarno <aurelien@aurel32.net>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org
Subject: Re: [PATCH 05/10] wdt: remove unused variables
Date: Wed, 15 Jun 2011 07:47:43 +0900 [thread overview]
Message-ID: <20110614224743.GG23200@valinux.co.jp> (raw)
In-Reply-To: <b2f8fb1259c46cd4d4ba521b881b05f1419d00a3.1308072799.git.mst@redhat.com>
It seems that I overlooked the variable when pci id conversion.
Acked-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
On Tue, Jun 14, 2011 at 08:35:52PM +0300, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/wdt_i6300esb.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c
> index bd57fd3..53786ce 100644
> --- a/hw/wdt_i6300esb.c
> +++ b/hw/wdt_i6300esb.c
> @@ -381,7 +381,6 @@ static const VMStateDescription vmstate_i6300esb = {
> static int i6300esb_init(PCIDevice *dev)
> {
> I6300State *d = DO_UPCAST(I6300State, dev, dev);
> - uint8_t *pci_conf;
> int io_mem;
> static CPUReadMemoryFunc * const mem_read[3] = {
> i6300esb_mem_readb,
> @@ -399,8 +398,6 @@ static int i6300esb_init(PCIDevice *dev)
> d->timer = qemu_new_timer_ns(vm_clock, i6300esb_timer_expired, d);
> d->previous_reboot_flag = 0;
>
> - pci_conf = d->dev.config;
> -
> io_mem = cpu_register_io_memory(mem_read, mem_write, d,
> DEVICE_NATIVE_ENDIAN);
> pci_register_bar_simple(&d->dev, 0, 0x10, 0, io_mem);
> --
> 1.7.5.53.gc233e
>
--
yamahata
next prev parent reply other threads:[~2011-06-14 22:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 17:35 [PATCH 00/10] qemu: remove set but unused variables Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 01/10] ppce500: move device/vendor/class id to qdev Michael S. Tsirkin
2011-06-14 22:42 ` Isaku Yamahata
2011-06-14 17:35 ` [PATCH 02/10] usb-ehci: " Michael S. Tsirkin
2011-06-14 17:35 ` [PATCH 03/10] usb-ehci: remove unused variables Michael S. Tsirkin
2011-06-15 6:45 ` Gerd Hoffmann
2011-06-14 17:35 ` [PATCH 04/10] lsi53c895a: " Michael S. Tsirkin
2011-06-15 9:23 ` Stefan Hajnoczi
2011-06-14 17:35 ` [PATCH 05/10] wdt: " Michael S. Tsirkin
2011-06-14 22:47 ` Isaku Yamahata [this message]
2011-06-14 17:36 ` [PATCH 06/10] kvm: " Michael S. Tsirkin
2011-06-15 7:38 ` Kevin Wolf
2011-06-15 8:25 ` Michael S. Tsirkin
2011-06-15 8:42 ` Jan Kiszka
2011-06-15 12:44 ` [Qemu-devel] " Chris Krumme
2011-06-15 18:29 ` Michael S. Tsirkin
2011-06-14 17:36 ` [PATCH 07/10] alpha/translate: remve " Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-14 17:36 ` [PATCH 08/10] alpha: remove unused variable Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-14 17:36 ` [PATCH 09/10] exec: " Michael S. Tsirkin
2011-06-26 11:08 ` Michael S. Tsirkin
2011-06-26 14:32 ` Stefan Hajnoczi
2011-06-14 17:36 ` [PATCH 10/10] linux-user: remove unused variables Michael S. Tsirkin
2011-06-15 8:35 ` Alexander Graf
2011-06-15 8:55 ` Michael S. Tsirkin
2011-06-15 14:32 ` Richard Henderson
2011-06-15 18:40 ` Michael S. Tsirkin
2011-06-15 23:42 ` [Qemu-devel] " Peter Maydell
2011-06-15 16:51 ` Peter Maydell
2011-06-26 11:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614224743.GG23200@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox