From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amos Kong Subject: Re: [PATCH 1/3] virtio: Correct error message of unavailable index Date: Thu, 16 Jun 2011 09:59:35 +0800 Message-ID: <20110616015935.GA2309@t400> References: <20110615142524.26726.13785.stgit@localhost6.localdomain6> <20110615203032.GA8362@redhat.com> Reply-To: Amos Kong Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304Ab1FPB7i (ORCPT ); Wed, 15 Jun 2011 21:59:38 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5G1xcES010383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Jun 2011 21:59:38 -0400 Content-Disposition: inline In-Reply-To: <20110615203032.GA8362@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 15, 2011 at 11:30:32PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 15, 2011 at 10:25:24PM +0800, Amos Kong wrote: > > 'head' is an index of VirtQueueElement, it should less than vring.num > > > > Signed-off-by: Amos Kong > > --- > > hw/virtio.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/hw/virtio.c b/hw/virtio.c > > index 6e8814c..a3d0eee 100644 > > --- a/hw/virtio.c > > +++ b/hw/virtio.c > > @@ -271,7 +271,7 @@ static unsigned int virtqueue_get_head(VirtQueue *vq, unsigned int idx) > > > > /* If their number is silly, that's a fatal mistake. */ > > if (head >= vq->vring.num) { > > - error_report("Guest says index %u is available", head); > > + error_report("Guest says index %u is unavailable", head); > > exit(1); > > } > > > > That does not seem right. So the message says that an illegal value > was made available - that is, put in the available ring. > The original message seems correct to me. It's my misunderstanding, thanks for pointing this.