Re: [PATCH 12/13] pci-assign: Generic config space access management

Avi Kivity
2011-06-28T08:21:08Z

On 06/28/2011 11:19 AM, Jan Kiszka wrote:
> On 2011-06-28 10:07, Avi Kivity wrote:
> > On 06/28/2011 01:48 AM, Alex Williamson wrote:
> >>> + memset(dev->direct_config_read + PCI_COMMAND, 0xff, 12);
> >> This is more efficient, but maybe we should memset each field for
> >> grep-ability.
> >
> > Agree. Or even
> >
> > pci_assign_set_direct_config(dev, register, start_bit, nr_bits);
>
> Given that pci_regs.h defines masks and not bits, working with |= and&=
> is more handy.

Ok. But a function is clearer than a memset.

--
error compiling committee.c: too many arguments to function