Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header

Michael S. Tsirkin
2011-06-28T12:07:14Z

On Tue, Jun 28, 2011 at 01:11:20PM +0200, Jan Kiszka wrote:
> On 2011-06-28 13:09, Michael S. Tsirkin wrote:
> > On Mon, Jun 27, 2011 at 08:19:47PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> No longer used.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > I think it's actually handy to build on old systems which have
> > a recent enough kernel but not the header.
> > Does it hurt much to keep it around?
>
> Unless I missed something, it's not part of any include search path. So
> how can it help?
>

We used to have compat last on search path. Is that no longer so?
I can try and dig up an old host that has this configuration.

> But if you think such a header is useful, then get it upstream.
>
> Jan

It's not upstream because we didn't used to have system
headers upstream. Now that we do it makes sense I think ...

--
MST