Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header

Jan Kiszka
2011-06-28T12:40:26Z

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On 2011-06-28 14:17, Michael S. Tsirkin wrote:
> On Tue, Jun 28, 2011 at 02:11:23PM +0200, Jan Kiszka wrote:
>> On 2011-06-28 14:07, Michael S. Tsirkin wrote:
>>> On Tue, Jun 28, 2011 at 01:11:20PM +0200, Jan Kiszka wrote:
>>>> On 2011-06-28 13:09, Michael S. Tsirkin wrote:
>>>>> On Mon, Jun 27, 2011 at 08:19:47PM +0200, Jan Kiszka wrote:
>>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>>
>>>>>> No longer used.
>>>>>>
>>>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>>>
>>>>> I think it's actually handy to build on old systems which have
>>>>> a recent enough kernel but not the header.
>>>>> Does it hurt much to keep it around?
>>>>
>>>> Unless I missed something, it's not part of any include search path. So
>>>> how can it help?
>>>>
>>>
>>> We used to have compat last on search path. Is that no longer so?
>>
>> I did a grep for "compat" and found nothing suspicious in configure or
>> some makefile. So this file looked like dead bits to me.
>>
>> Jan
>>
>
> kvm_cflags="$kvm_cflags -idirafter $source_path/compat"
>

I see. That was dropped with the recent upstream merge (c13a890960).

Please check what setup benefited from it, and then discuss if and how
to reintroduce it via upstream.

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]