From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 00/13] qemu-kvm: device assignment cleanups and upstream diff reductions Date: Tue, 28 Jun 2011 11:57:02 +0300 Message-ID: <20110628085702.GN10881@redhat.com> References: <4E098C5C.7060800@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kiszka , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson , Joerg Roedel To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25723 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756253Ab1F1I4q (ORCPT ); Tue, 28 Jun 2011 04:56:46 -0400 Content-Disposition: inline In-Reply-To: <4E098C5C.7060800@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 28, 2011 at 11:10:04AM +0300, Avi Kivity wrote: > On 06/27/2011 09:19 PM, Jan Kiszka wrote: > >This series basically consists of two halves. The first one applies a > >few smaller cleanups to qemu-kvm to improve similarity with upstream. > >This includes the recently discussed removal of -enable-nesting. > > > >The second half starts with two device assignment fixes and then applies > >some refactorings, specifically dropping the libpci dependency and > >enabling the revert of some qemu-kvm private PCI core changes. The > >latter is achieved by simplifying the access control management to the > >passed-through device's config space. That also saves 100 LOC. > > > >Note that this series was tested with upstream commit af2be20777 ("Fix > >fallouts from Linux header inclusion") applied and probably depends on > >it also mechanically. > > > >Please review/merge. > > > > Thanks, applied 1-6. The rest looks good as well, just need the few > comments attended to. 7-11 look good to me too. > -- > error compiling committee.c: too many arguments to function