From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header Date: Tue, 28 Jun 2011 15:07:33 +0300 Message-ID: <20110628120733.GB6395@redhat.com> References: <20110628110908.GB5661@redhat.com> <4E09B6D8.1010406@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55903 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757255Ab1F1MHO (ORCPT ); Tue, 28 Jun 2011 08:07:14 -0400 Content-Disposition: inline In-Reply-To: <4E09B6D8.1010406@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 28, 2011 at 01:11:20PM +0200, Jan Kiszka wrote: > On 2011-06-28 13:09, Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2011 at 08:19:47PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> No longer used. > >> > >> Signed-off-by: Jan Kiszka > > > > I think it's actually handy to build on old systems which have > > a recent enough kernel but not the header. > > Does it hurt much to keep it around? > > Unless I missed something, it's not part of any include search path. So > how can it help? > We used to have compat last on search path. Is that no longer so? I can try and dig up an old host that has this configuration. > But if you think such a header is useful, then get it upstream. > > Jan It's not upstream because we didn't used to have system headers upstream. Now that we do it makes sense I think ... -- MST