From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 04/13] qemu-kvm: Remove eventfd compat header Date: Tue, 28 Jun 2011 15:17:19 +0300 Message-ID: <20110628121719.GA6543@redhat.com> References: <20110628110908.GB5661@redhat.com> <4E09B6D8.1010406@web.de> <20110628120733.GB6395@redhat.com> <4E09C4EB.1000409@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, Alex Williamson To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2239 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757530Ab1F1MRB (ORCPT ); Tue, 28 Jun 2011 08:17:01 -0400 Content-Disposition: inline In-Reply-To: <4E09C4EB.1000409@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 28, 2011 at 02:11:23PM +0200, Jan Kiszka wrote: > On 2011-06-28 14:07, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2011 at 01:11:20PM +0200, Jan Kiszka wrote: > >> On 2011-06-28 13:09, Michael S. Tsirkin wrote: > >>> On Mon, Jun 27, 2011 at 08:19:47PM +0200, Jan Kiszka wrote: > >>>> From: Jan Kiszka > >>>> > >>>> No longer used. > >>>> > >>>> Signed-off-by: Jan Kiszka > >>> > >>> I think it's actually handy to build on old systems which have > >>> a recent enough kernel but not the header. > >>> Does it hurt much to keep it around? > >> > >> Unless I missed something, it's not part of any include search path. So > >> how can it help? > >> > > > > We used to have compat last on search path. Is that no longer so? > > I did a grep for "compat" and found nothing suspicious in configure or > some makefile. So this file looked like dead bits to me. > > Jan > kvm_cflags="$kvm_cflags -idirafter $source_path/compat"