From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] tools/kvm: Use kernel header version of net/9p/9p.h Date: Sat, 2 Jul 2011 12:25:31 +0200 Message-ID: <20110702102531.GD17482@elte.hu> References: <1309503045-18431-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Aneesh Kumar K.V" , levinsasha928@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:34905 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752471Ab1GBKZl (ORCPT ); Sat, 2 Jul 2011 06:25:41 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: * Pekka Enberg wrote: > On Fri, 1 Jul 2011, Aneesh Kumar K.V wrote: > >don't do a copy of the kernel header > > > >Signed-off-by: Aneesh Kumar K.V >=20 > I see this error with your patch applied: >=20 > cc1: warnings being treated as errors > In file included from virtio/9p.c:20: > ../../include/net/9p/9p.h:723: error: redundant redeclaration of > =E2=80=98p9_errstr2errno=E2=80=99 > ../../include/net/9p/9p.h:714: note: previous declaration of > =E2=80=98p9_errstr2errno=E2=80=99 was here > make: *** [virtio/9p.o] Error 1 >=20 > The tree is based on v2.6.37 so maybe the problem got fixed after > that. I guess I could do >=20 > git merge v2.6.39 >=20 > to our tree. Ingo? I'd suggest 'git merge v3.0-rc5' - as the kernel is in a late -rc=20 already and pretty mature. Also, we should probably add 'kvm --version' a'ka: aldebaran:~> perf --version perf version 3.0.rc5.1398.g8cf400.dirty To make it easier to report bugs. Thanks, Ingo