From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] ioeventfd: Introduce KVM_IOEVENTFD_FLAG_PIPE Date: Mon, 4 Jul 2011 15:12:04 +0300 Message-ID: <20110704121204.GF11386@redhat.com> References: <1309712689-4290-1-git-send-email-levinsasha928@gmail.com> <20110704103207.GA11386@redhat.com> <4E1199B3.2010507@redhat.com> <20110704110723.GD11386@redhat.com> <4E11A1CB.2080709@redhat.com> <20110704114503.GE11386@redhat.com> <4E11A8C3.2010603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sasha Levin , kvm@vger.kernel.org, Ingo Molnar , Marcelo Tosatti , Pekka Enberg To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25901 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707Ab1GDMLx (ORCPT ); Mon, 4 Jul 2011 08:11:53 -0400 Content-Disposition: inline In-Reply-To: <4E11A8C3.2010603@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 04, 2011 at 02:49:23PM +0300, Avi Kivity wrote: > On 07/04/2011 02:45 PM, Michael S. Tsirkin wrote: > >On Mon, Jul 04, 2011 at 02:19:39PM +0300, Avi Kivity wrote: > >> >Also noting that the fd can be set not to block, or that > >> >a signal can interrupt the write. Both cases are not errors. > >> > >> One thing we can do is return via the normal KVM_EXIT_MMIO method > >> and hope userspace knows how to handle this. > > > >Agree. We'll need some way to tell userspace that > >write has partially succeeded, presumably, so that > >userspace can write out the missing part. > > With SOCK_SEQPACKET, there will be no partial writes. Good idea. I think the same applies to netlink sockets. > -- > error compiling committee.c: too many arguments to function