From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v3 05/19] KVM: MMU: optimize to handle dirty bit Date: Thu, 7 Jul 2011 05:15:41 -0300 Message-ID: <20110707081540.GA8334@amt.cnet> References: <4E0C3178.2080603@cn.fujitsu.com> <4E0C320A.8080104@cn.fujitsu.com> <20110705192703.GB24417@amt.cnet> <4E13B8D4.3050704@cn.fujitsu.com> <20110706165134.GC24417@amt.cnet> <4E14B39A.5020401@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , LKML , KVM To: Xiao Guangrong Return-path: Content-Disposition: inline In-Reply-To: <4E14B39A.5020401@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Thu, Jul 07, 2011 at 03:12:26AM +0800, Xiao Guangrong wrote: > >> So, i think it works well :-) > > > > I think you meant after marking the accessed bit. The dirty bit is set > > just before returning. > > > > In this patch, i moved getting pte_access to the behind of setting dirty bit set OK