From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Khlebnikov Subject: [PATCH] kvm tools: fix instances enumeration Date: Sun, 10 Jul 2011 16:13:27 +0400 Message-ID: <20110710121327.2081.32899.stgit@localhost6> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Return-path: Received: from relay.parallels.com ([195.214.232.42]:38701 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755874Ab1GJMN3 (ORCPT ); Sun, 10 Jul 2011 08:13:29 -0400 Received: from msk-exch1.sw.swsoft.com ([10.30.1.231] helo=mail.sw.ru) by relay.parallels.com with esmtps (TLSv1:RC4-MD5:128) (Exim 4.74) (envelope-from ) id 1Qfst6-0002ZD-DW for kvm@vger.kernel.org; Sun, 10 Jul 2011 16:13:28 +0400 Sender: kvm-owner@vger.kernel.org List-ID: Calling readdir() with NULL dirp leads to segfault. Signed-off-by: Konstantin Khlebnikov --- tools/kvm/kvm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/kvm/kvm.c b/tools/kvm/kvm.c index cd3cb19..2ac7b38 100644 --- a/tools/kvm/kvm.c +++ b/tools/kvm/kvm.c @@ -172,7 +172,7 @@ int kvm__enumerate_instances(void (*callback)(const char *name, int pid)) sprintf(full_name, "%s/%s", HOME_DIR, KVM_PID_FILE_PATH); dir = opendir(full_name); - for (;;) { + for (;dir;) { readdir_r(dir, &entry, &result); if (result == NULL) break;