From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/3] qemu-x86: Add tsc_freq option to -cpu Date: Tue, 19 Jul 2011 09:56:06 -0300 Message-ID: <20110719125606.GA29108@amt.cnet> References: <1310047993-7649-1-git-send-email-joerg.roedel@amd.com> <1310047993-7649-3-git-send-email-joerg.roedel@amd.com> <20110719114658.GA28500@amt.cnet> <4E257695.4010906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Joerg Roedel , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8859 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab1GSNAD (ORCPT ); Tue, 19 Jul 2011 09:00:03 -0400 Content-Disposition: inline In-Reply-To: <4E257695.4010906@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 19, 2011 at 03:20:37PM +0300, Avi Kivity wrote: > On 07/19/2011 02:46 PM, Marcelo Tosatti wrote: > >On Thu, Jul 07, 2011 at 04:13:12PM +0200, Joerg Roedel wrote: > >> To let the user configure the desired tsc frequency for the > >> guest if running in KVM. > >> > >> Signed-off-by: Joerg Roedel > >> --- > >> target-i386/cpu.h | 1 + > >> target-i386/cpuid.c | 13 +++++++++++++ > >> 2 files changed, 14 insertions(+), 0 deletions(-) > >> > >> diff --git a/target-i386/cpu.h b/target-i386/cpu.h > >> index cdf68ff..399e124 100644 > >> --- a/target-i386/cpu.h > >> +++ b/target-i386/cpu.h > >> @@ -743,6 +743,7 @@ typedef struct CPUX86State { > >> uint32_t cpuid_kvm_features; > >> uint32_t cpuid_svm_features; > >> bool tsc_valid; > >> + int tsc_khz; > > > >This should be saved/restore in migration data (missing VMSTATE entry). > > Why? It's static data. Traditionally we only migrate runtime data. > > (although we've been talking about starting a naked qemu and pushing > all of the configuration from the source). Right.