From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC v4 00/58] Memory API Date: Tue, 19 Jul 2011 16:56:01 +0300 Message-ID: <20110719135601.GA7194@redhat.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61819 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab1GSNzd (ORCPT ); Tue, 19 Jul 2011 09:55:33 -0400 Content-Disposition: inline In-Reply-To: <1310901265-32051-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > New in this version: > MemoryRegionOps gained .old_mmio and .old_portio members, which allow > reusing old-style callbacks with the new API. All uses were converted, > except for eepro100.c, which uses the same MemoryRegionOps for both > portio and mmio. Some intermediate patches do introduce dispatching > callbacks, but they are removed later. > > Caveats: > - some devices still grab a global memory region instead of inheriting > it from their bus. Seen in the code as #include "exec-memory.h" Looks good to me. It looks like with this, users of vga_dirty_log_stop like qxl_write_config can go away because the region can stay registered with dirty logging enabled? -- MST