From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes Date: Mon, 25 Jul 2011 16:31:24 +0300 Message-ID: <20110725133124.GG4404@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> <4E2D6A97.9050606@codemonkey.ws> <4E2D6C45.5030308@redhat.com> <20110725131728.GD4404@redhat.com> <4E2D6F6C.5070301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=cp1255 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35358 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416Ab1GYNb2 convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2011 09:31:28 -0400 Content-Disposition: inline In-Reply-To: <4E2D6F6C.5070301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jul 25, 2011 at 04:28:12PM +0300, Avi Kivity wrote: > On 07/25/2011 04:17 PM, Gleb Natapov wrote: > >On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: > >> On 07/25/2011 04:07 PM, Anthony Liguori wrote: > >> >On 07/20/2011 11:50 AM, Avi Kivity wrote: > >> >>The current implementation of PAM and the PCI holes is broken i= n several > >> >>ways: > >> >> > >> >> - PCI BARs are not restricted to the PCI hole (a BAR may hi= de memory) > >> > > >> >Technically, a BAR can be mapped to any non-RAM memory location. > >> > >> I understood TOM (Top Of Memory) to be fixed - can't find a regis= ter > >> for it - but maybe I misread the spec. > >> > >PIIX3 spec: > > > >2.2.11. TOM=97TOP OF MEMORY REGISTER (Function 0) > >Address Offset: 69h > >Default Value: 02h > >Attribute: Read/Write > > >=20 > What's it doing in PIIX3? Is it the same TOM? >=20 Good question. Looks like it is not: This register enables the forwarding of ISA or DMA memory cycles to the PCI Bus and sets the top of main memory accessible by ISA or DMA devices. In addition, this register controls the forwarding of ISA or DMA accesses to the lower BIOS region (E0000=96EFFFFh) and the 512=96640-Kb= yte main memory region (80000=96 9FFFFh). The Top Of Memory configuration register must be set by the BIOS. -- Gleb.