From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Donald Dutile <ddutile@redhat.com>,
kvm@vger.kernel.org, alex.williamson@redhat.com, mst@redhat.com
Subject: Re: [PATCH] dev-assignment: handle device with incorrect PCIe Cap structure size
Date: Mon, 1 Aug 2011 12:56:28 -0300 [thread overview]
Message-ID: <20110801155628.GC4285@amt.cnet> (raw)
In-Reply-To: <4E36CC0D.7070907@redhat.com>
On Mon, Aug 01, 2011 at 06:53:49PM +0300, Avi Kivity wrote:
> On 08/01/2011 06:50 PM, Marcelo Tosatti wrote:
> >On Tue, Jul 26, 2011 at 06:08:09PM -0400, Donald Dutile wrote:
> >> The bcm5761 provides a PCIe Cap structure (capid=0x10)
> >> that is invalid, providing one that is 8 bytes shorter
> >> than the v2 PCIe spec defines.
> >> This leads to a memory corruption when mapped for device-assigment.
> >>
> >> Add a check in assigned_device_pci_cap_init() to correct
> >> this hw error for this device, and try to catch other ones
> >> and print warnings if they exists.
> >>
> >> Signed-off-by: Donald Dutile<ddutile@redhat.com>
> >> cc: Alex Williamson<alex.williamson@redhat.com>
> >> cc: Michael S. Tsirking<mst@redhat.com>
> >
> >Patch does not apply cleanly, complaints about trailing whitespaces.
> >
> >Please regenerate against current git tree, thanks.
> >
>
> I thought I applied it already, I even remember the trailing
> whitespace complaints (which git fixed for me).
>
> I hope we didn't lose other patches this way.
OK. Its not lost:
commit f9c29774d2174df6ffc20becec20928948198914
Author: Donald Dutile <ddutile@redhat.com>
Date: Tue Jul 26 18:08:09 2011 -0400
device-assignment: handle device with incorrect PCIe Cap structure size
next prev parent reply other threads:[~2011-08-01 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 22:08 [PATCH] dev-assignment: handle device with incorrect PCIe Cap structure size Donald Dutile
2011-07-26 22:32 ` Alex Williamson
2011-07-27 7:48 ` Michael S. Tsirkin
2011-07-27 9:27 ` Avi Kivity
2011-08-01 15:50 ` Marcelo Tosatti
2011-08-01 15:53 ` Avi Kivity
2011-08-01 15:56 ` Marcelo Tosatti [this message]
2011-08-01 16:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110801155628.GC4285@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=ddutile@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox