Re: [RFC PATCH v2 1/3] separate thread for VM migration

Paolo Bonzini
2011-08-02T07:44:26Z

On 08/01/2011 11:00 PM, Umesh Deshpande wrote:
>>
> I kept this in migration.c to call qemu_savevm_state_begin. (The way it
> is done currently. i.e. to keep access to FdMigrationState in migration.c)
> Calling it from buffered_file.c would be inconsistent in that sense. or
> we will have to call it from the iothread before spawning the migration
> thread.

Right, I missed that. Perhaps you can call it the first time put_ready
is called.

> Also why is the separation between FdMigrationState and QEMUFileBuffered
> is required. Is QEMUFileBuffered designed to use also for things other
> than migration?

No, but let's keep it this way for now. It may be an annoyance, but it
also helps making a reusable architecture, and it can probably be
cleaned up substantially with thread support.

Paolo