* [PATCH 4/11] arch/x86/kvm/vmx.c: trivial: use BUG_ON [not found] <1312281304-11847-1-git-send-email-julia@diku.dk> @ 2011-08-02 10:34 ` Julia Lawall 2011-08-02 16:44 ` Marcelo Tosatti 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2011-08-02 10:34 UTC (permalink / raw) To: Avi Kivity, trivial Cc: kernel-janitors, Marcelo Tosatti, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm, linux-kernel From: Julia Lawall <julia@diku.dk> Use BUG_ON(x) rather than if(x) BUG(); The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x); @@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> --- arch/x86/kvm/vmx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -u -p a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -4115,8 +4115,7 @@ static int handle_exception(struct kvm_v error_code = vmcs_read32(VM_EXIT_INTR_ERROR_CODE); if (is_page_fault(intr_info)) { /* EPT won't cause page fault directly */ - if (enable_ept) - BUG(); + BUG_ON(enable_ept); cr2 = vmcs_readl(EXIT_QUALIFICATION); trace_kvm_page_fault(cr2, error_code); ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/11] arch/x86/kvm/vmx.c: trivial: use BUG_ON 2011-08-02 10:34 ` [PATCH 4/11] arch/x86/kvm/vmx.c: trivial: use BUG_ON Julia Lawall @ 2011-08-02 16:44 ` Marcelo Tosatti 0 siblings, 0 replies; 2+ messages in thread From: Marcelo Tosatti @ 2011-08-02 16:44 UTC (permalink / raw) To: Julia Lawall Cc: Avi Kivity, trivial, kernel-janitors, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm, linux-kernel On Tue, Aug 02, 2011 at 12:34:57PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Use BUG_ON(x) rather than if(x) BUG(); > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ identifier x; @@ > -if (x) BUG(); > +BUG_ON(x); > > @@ identifier x; @@ > -if (!x) BUG(); > +BUG_ON(!x); > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> Applied, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-02 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1312281304-11847-1-git-send-email-julia@diku.dk>
2011-08-02 10:34 ` [PATCH 4/11] arch/x86/kvm/vmx.c: trivial: use BUG_ON Julia Lawall
2011-08-02 16:44 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox