From: Bandan Das <bandan.das@stratus.com>
To: "Nadav Har'El" <nyh@il.ibm.com>
Cc: kvm@vger.kernel.org, "Roedel, Joerg" <Joerg.Roedel@amd.com>,
Zachary Amsden <zamsden@gmail.com>,
Bandan Das <bandan.das@stratus.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
avi@redhat.com, jan.kiszka@web.de, matt.mcgill@gmail.com
Subject: Re: [PATCH 0/3] Nested TSC handling
Date: Tue, 2 Aug 2011 15:24:29 -0400 [thread overview]
Message-ID: <20110802192429.GD19569@stratus.com> (raw)
In-Reply-To: <1312289591-nyh@il.ibm.com>
On 0, Nadav Har'El <nyh@il.ibm.com> wrote:
> The following are patches I propose for fixing the bug discovered by Bandan
> Das and discussed in the "Nested VMX - L1 hangs on running L2" thread.
>
> The first patch should fix the originally-reported bug, as explained in the
> aforementioned thread: A new x86_op read_l1_tsc() is called L1's TSC is
> needed, instead of assuming that calling kvm_read_msr() will do that
> (because this has to return L2's TSC when a nested guest is running).
>
> The second and third patches fix relatively-unimportant corner cases in
> nested VMX and nested SVM TSC handling.
>
> I'd appreciate it if the people who noticed this bug can verify that these
> patches indeed solve it for them.
I can verify that these patches work for me. Thanks Nadav and others for looking
into this!
I have cc'ed Jan and Matt in case they would be interested in trying out
these patches.
> Patch statistics:
> -----------------
>
> arch/x86/include/asm/kvm_host.h | 2 +
> arch/x86/kvm/svm.c | 13 ++++++--
> arch/x86/kvm/vmx.c | 48 +++++++++++++++++++++++-------
> arch/x86/kvm/x86.c | 8 ++---
> 4 files changed, 54 insertions(+), 17 deletions(-)
>
> --
> Nadav Har'El
> IBM Haifa Research Lab
next prev parent reply other threads:[~2011-08-02 19:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 12:53 [PATCH 0/3] Nested TSC handling Nadav Har'El
2011-08-02 12:54 ` [PATCH 1/3] L1 " Nadav Har'El
2011-08-03 7:54 ` Zachary Amsden
2011-08-02 12:54 ` [PATCH 2/3] Fix nested VMX TSC emulation Nadav Har'El
2011-08-03 8:19 ` Zachary Amsden
2011-08-03 8:35 ` Nadav Har'El
2011-08-02 12:55 ` [PATCH 3/3] Fix TSC MSR read in nested SVM Nadav Har'El
2011-08-03 8:34 ` Zachary Amsden
2011-08-03 11:29 ` Nadav Har'El
2011-08-03 21:00 ` Marcelo Tosatti
2011-08-05 15:32 ` Marcelo Tosatti
2011-08-06 12:16 ` Joerg Roedel
2011-08-07 12:04 ` Joerg Roedel
2011-08-10 12:35 ` Nadav Har'El
2011-08-10 13:02 ` Joerg Roedel
2011-08-02 19:24 ` Bandan Das [this message]
2011-08-02 19:54 ` [PATCH 0/3] Nested TSC handling Matt McGill
2011-08-10 15:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802192429.GD19569@stratus.com \
--to=bandan.das@stratus.com \
--cc=Joerg.Roedel@amd.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=matt.mcgill@gmail.com \
--cc=mtosatti@redhat.com \
--cc=nyh@il.ibm.com \
--cc=zamsden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox