From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 20/39] virtio-pci: convert to memory API Date: Wed, 3 Aug 2011 18:38:53 +0300 Message-ID: <20110803153853.GB16088@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-21-git-send-email-avi@redhat.com> <20110801082600.GD5439@redhat.com> <4E367370.6070100@redhat.com> <20110801102322.GF5439@redhat.com> <20110803151635.GA15804@redhat.com> <4E3967FD.8000301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33703 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934Ab1HCPiR (ORCPT ); Wed, 3 Aug 2011 11:38:17 -0400 Content-Disposition: inline In-Reply-To: <4E3967FD.8000301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Aug 03, 2011 at 06:23:41PM +0300, Avi Kivity wrote: > On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote: > >> > >> Well, the reason we have this logic here, I think, is > >> to make sure it runs before the guest accesses > >> the configuration with a write access. > >> > >> I'm not sure why we don't do this in the init > >> callback - Anthony? > > > >So the following should do this. > >Anthony, could you ack please? > > > >Avi, this is on top of the memory API branch. > >But since it's not exactly the same, > >maybe this should go in *before* the memory API > >patches, to make it easier to bisect etc? > > > >You decide. > > How can I decide? This is your area. > > I'll be happy to rebase if needed. OK, I've sent a patch, pls stick it on your branch and your changes can go on top. Thanks! > -- > error compiling committee.c: too many arguments to function