* [PATCH -next] kvm: uses TASKSTATS, depends on NET [not found] <20110802155727.a3d76babdd2c6fd5d33928c5@canb.auug.org.au> @ 2011-08-02 19:54 ` Randy Dunlap 2011-08-03 21:02 ` Marcelo Tosatti 0 siblings, 1 reply; 2+ messages in thread From: Randy Dunlap @ 2011-08-02 19:54 UTC (permalink / raw) To: Stephen Rothwell, Avi Kivity, Marcelo Tosatti; +Cc: linux-next, LKML, kvm From: Randy Dunlap <rdunlap@xenotime.net> CONFIG_TASKSTATS just had a change to use netlink, including a change to "depends on NET". Since "select" does not follow dependencies, KVM also needs to depend on NET to prevent build errors when CONFIG_NET is not enabled. Sample of the reported "undefined reference" build errors: taskstats.c:(.text+0x8f686): undefined reference to `nla_put' taskstats.c:(.text+0x8f721): undefined reference to `nla_reserve' taskstats.c:(.text+0x8f8fb): undefined reference to `init_net' taskstats.c:(.text+0x8f905): undefined reference to `netlink_unicast' taskstats.c:(.text+0x8f934): undefined reference to `kfree_skb' taskstats.c:(.text+0x8f9e9): undefined reference to `skb_clone' taskstats.c:(.text+0x90060): undefined reference to `__alloc_skb' taskstats.c:(.text+0x901e9): undefined reference to `skb_put' taskstats.c:(.init.text+0x4665): undefined reference to `genl_register_family' taskstats.c:(.init.text+0x4699): undefined reference to `genl_register_ops' taskstats.c:(.init.text+0x4710): undefined reference to `genl_unregister_ops' taskstats.c:(.init.text+0x471c): undefined reference to `genl_unregister_family' Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> --- arch/x86/kvm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) --- linux-next-20110802.orig/arch/x86/kvm/Kconfig +++ linux-next-20110802/arch/x86/kvm/Kconfig @@ -22,6 +22,8 @@ config KVM depends on HAVE_KVM # for device assignment: depends on PCI + # for TASKSTATS/TASK_DELAY_ACCT: + depends on NET select PREEMPT_NOTIFIERS select MMU_NOTIFIER select ANON_INODES ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] kvm: uses TASKSTATS, depends on NET 2011-08-02 19:54 ` [PATCH -next] kvm: uses TASKSTATS, depends on NET Randy Dunlap @ 2011-08-03 21:02 ` Marcelo Tosatti 0 siblings, 0 replies; 2+ messages in thread From: Marcelo Tosatti @ 2011-08-03 21:02 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, Avi Kivity, linux-next, LKML, kvm On Tue, Aug 02, 2011 at 12:54:31PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@xenotime.net> > > CONFIG_TASKSTATS just had a change to use netlink, including > a change to "depends on NET". Since "select" does not follow > dependencies, KVM also needs to depend on NET to prevent build > errors when CONFIG_NET is not enabled. > > Sample of the reported "undefined reference" build errors: > > taskstats.c:(.text+0x8f686): undefined reference to `nla_put' > taskstats.c:(.text+0x8f721): undefined reference to `nla_reserve' > taskstats.c:(.text+0x8f8fb): undefined reference to `init_net' > taskstats.c:(.text+0x8f905): undefined reference to `netlink_unicast' > taskstats.c:(.text+0x8f934): undefined reference to `kfree_skb' > taskstats.c:(.text+0x8f9e9): undefined reference to `skb_clone' > taskstats.c:(.text+0x90060): undefined reference to `__alloc_skb' > taskstats.c:(.text+0x901e9): undefined reference to `skb_put' > taskstats.c:(.init.text+0x4665): undefined reference to `genl_register_family' > taskstats.c:(.init.text+0x4699): undefined reference to `genl_register_ops' > taskstats.c:(.init.text+0x4710): undefined reference to `genl_unregister_ops' > taskstats.c:(.init.text+0x471c): undefined reference to `genl_unregister_family' > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Applied, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-03 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110802155727.a3d76babdd2c6fd5d33928c5@canb.auug.org.au>
2011-08-02 19:54 ` [PATCH -next] kvm: uses TASKSTATS, depends on NET Randy Dunlap
2011-08-03 21:02 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox